From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 08/12] xfs: read primary superblock from disk during scrub
Date: Thu, 24 Sep 2026 22:39:17 -0700 [thread overview]
Message-ID: <arYJBQswkVIENLcj@infradead.org> (raw)
In-Reply-To: <179030932219.3344850.3980099326844933037.stgit@frogsfrogsfrogs>
On Thu, Sep 24, 2026 at 09:12:35PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The primary superblock scrubber isn't that useful right now because the
> disk contents could have been corrupted after mount time. Perform an
> uncached re-read of the super buffer to perform a fresh verification,
> and schedule a repair if it doesn't pass muster.
Can we have a test exercising this?
The patch itself looks good assuming we have something that actually
exercises this new code:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-25 5:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 4:10 [PATCHSET] xfs: LLM-inspired bug fixes, part 18 Darrick J. Wong
2026-09-25 4:10 ` [PATCH 01/12] xfs: adjust checks for cross-AG reaping issues Darrick J. Wong
2026-09-25 5:33 ` Christoph Hellwig
2026-09-25 4:11 ` [PATCH 02/12] xfs: actually check XFS_DIFLAG2_METADATA for metadata btree data forks Darrick J. Wong
2026-09-25 5:33 ` Christoph Hellwig
2026-09-25 4:11 ` [PATCH 03/12] xfs: fix xchk_stats_estimate_bufsize to allow for the trailing null Darrick J. Wong
2026-09-25 5:34 ` Christoph Hellwig
2026-09-25 4:11 ` [PATCH 04/12] xfs: cross-reference the primary superblock Darrick J. Wong
2026-09-25 5:35 ` Christoph Hellwig
2026-09-25 4:11 ` [PATCH 05/12] xfs: write the rt super immediately during repair Darrick J. Wong
2026-09-25 5:36 ` Christoph Hellwig
2026-09-25 4:12 ` [PATCH 06/12] xfs: read rt superblock from disk during scrub Darrick J. Wong
2026-09-25 5:37 ` Christoph Hellwig
2026-09-25 4:12 ` [PATCH 07/12] xfs: write the primary super immediately during repair Darrick J. Wong
2026-09-25 5:38 ` Christoph Hellwig
2026-09-25 4:12 ` [PATCH 08/12] xfs: read primary superblock from disk during scrub Darrick J. Wong
2026-09-25 5:39 ` Christoph Hellwig [this message]
2026-09-25 4:12 ` [PATCH 09/12] xfs: break out of zoned reservation loop if signals are pending Darrick J. Wong
2026-09-25 5:41 ` Christoph Hellwig
2026-09-25 19:18 ` Darrick J. Wong
2026-09-25 19:37 ` Darrick J. Wong
2026-09-25 4:13 ` [PATCH 10/12] xfs: jump out of xchk_bmap_check_rmap if fatal signals Darrick J. Wong
2026-09-25 5:42 ` Christoph Hellwig
2026-09-25 4:13 ` [PATCH 11/12] xfs: mark overfull dabtree node blocks as corrupt Darrick J. Wong
2026-09-25 5:42 ` Christoph Hellwig
2026-09-25 4:13 ` [PATCH 12/12] xfs: check fork type against dabtree block magic number Darrick J. Wong
2026-09-25 5:42 ` Christoph Hellwig
2026-10-08 13:32 ` [PATCHSET] xfs: LLM-inspired bug fixes, part 18 Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arYJBQswkVIENLcj@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.