From: Mike Rapoport <rppt@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>, Len Brown <lenb@kernel.org>,
Pavel Machek <pavel@kernel.org>,
kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/5] hibernation, KFENCE: explicitly map/unmap KFENCE pages
Date: Fri, 25 Sep 2026 12:33:07 +0300 [thread overview]
Message-ID: <arY_058nsjb_Ie1l@kernel.org> (raw)
In-Reply-To: <c01aa1e3-f2cd-4b28-8e6a-8e8a1c36c641@kernel.org>
On Thu, Sep 24, 2026 at 08:49:13PM +0200, David Hildenbrand (Arm) wrote:
> On 9/24/26 18:02, Mike Rapoport wrote:
> > On Thu, Sep 24, 2026 at 10:19:33AM +0200, David Hildenbrand (Arm) wrote:
> >> On 9/23/26 17:49, Mike Rapoport wrote:
> >>>
> >>> Naming is hard :-D
> >>>
> >>> I feel that _copy_page() is to vague and adding hibernation there is to
> >>> mouthful :(
> >>
> >> Yeah, I wouldn't mention hibernation.
> >>
> >>
> >>
> >>>
> >>> And these could be used outside of safe_copy_page() someday.
> >>>
> >>> How about
> >>>
> >>> kfence_set_page_present()
> >>> kfence_set_page_default()
> >>
> >>
> >> Maybe spell out "direct_map" ?
> >>
> >> kfence_set_direct_map_present()
> >>
> >> kfence_set_direct_map_default()
> >
> > They are not necessarily in direct map :)
> > loongarch does not have direct map, but still supports kfence
>
> Ugh :D
>
> But where are the pages mapped/unmapped then?
loongarch remaps them into vmalloc address space and sets page->virtual for
page_address() to work.
> (I know, I should read your doc patch)
>
> --
> Cheers,
>
> David
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-09-25 9:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 6:07 [PATCH 0/5] hibernation: make safe_copy_page more robust and remove debug_pagealloc support Mike Rapoport (Microsoft)
2026-09-17 6:07 ` [PATCH 1/5] hibernation: make swsusp_page helpers static Mike Rapoport (Microsoft)
2026-09-23 10:08 ` David Hildenbrand (Arm)
2026-09-17 6:07 ` [PATCH 2/5] hibernation: ensure secretmem pages don't reach a snapshot Mike Rapoport (Microsoft)
2026-09-23 10:10 ` David Hildenbrand (Arm)
2026-09-23 15:38 ` Mike Rapoport
2026-09-17 6:07 ` [PATCH 3/5] hibernate: handle potential errors in hibernate_{map,unmap}_page() Mike Rapoport (Microsoft)
2026-09-23 10:13 ` David Hildenbrand (Arm)
2026-09-23 15:42 ` Mike Rapoport
2026-09-24 8:16 ` David Hildenbrand (Arm)
2026-09-17 6:07 ` [PATCH 4/5] hibernation, KFENCE: explicitly map/unmap KFENCE pages Mike Rapoport (Microsoft)
2026-09-23 10:31 ` David Hildenbrand (Arm)
2026-09-23 15:49 ` Mike Rapoport
2026-09-24 8:19 ` David Hildenbrand (Arm)
2026-09-24 16:02 ` Mike Rapoport
2026-09-24 18:49 ` David Hildenbrand (Arm)
2026-09-25 9:33 ` Mike Rapoport [this message]
2026-09-25 11:00 ` David Hildenbrand (Arm)
2026-09-17 6:07 ` [PATCH 5/5] hibernation: make hibernation unavailable when debug_pagealloc is on Mike Rapoport (Microsoft)
2026-09-23 10:24 ` David Hildenbrand (Arm)
2026-09-23 9:26 ` [PATCH 0/5] hibernation: make safe_copy_page more robust and remove debug_pagealloc support Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arY_058nsjb_Ie1l@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.