From: Christoph Hellwig <hch@infradead.org>
To: Julian Sun <sunjunchao@bytedance.com>
Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
axboe@kernel.dk, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
muchun.song@linux.dev, willy@infradead.org, jack@suse.cz,
tj@kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v9 1/3] block: introduce bdev_flush_by_dev()
Date: Thu, 24 Sep 2026 23:52:33 -0700 [thread overview]
Message-ID: <arYaMbJUh6unvz_t@infradead.org> (raw)
In-Reply-To: <20260925064444.3944820-2-sunjunchao@bytedance.com>
On Fri, Sep 25, 2026 at 02:44:42PM +0800, Julian Sun wrote:
> Add bdev_flush_by_dev() to submit page-cache writeback for a device
> identified by dev_t without requiring callers to hold a persistent
> device reference.
This isn't really a flush is it? This is writeback.
> + *
> + * May sleep while submitting writeback; does not wait for I/O completion.
> + */
> +void bdev_flush_by_dev(dev_t dev)
> +{
> + struct block_device *bdev;
> +
> + bdev = blkdev_get_no_open(dev, false);
> + if (!bdev)
> + return;
Please don't add more blkdev_get_no_open. You can get from an
bdevfs inode to the struct block_device trivially using
I_BDEV instead of doing another lookup. Or just grab a reference
to the the inode, which would seem even easier.
next prev parent reply other threads:[~2026-09-25 6:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 6:44 [PATCH v9 0/3] memcg,writeback: flush foreign bdev mappings separately Julian Sun
2026-09-25 6:44 ` [PATCH v9 1/3] block: introduce bdev_flush_by_dev() Julian Sun
2026-09-25 6:52 ` Christoph Hellwig [this message]
2026-09-25 10:34 ` Jan Kara
2026-09-28 6:24 ` Christoph Hellwig
2026-09-28 9:51 ` Julian Sun
2026-10-02 11:10 ` Jan Kara
2026-10-05 8:26 ` Christoph Hellwig
2026-10-05 16:25 ` Jan Kara
2026-10-08 8:00 ` Julian Sun
2026-10-08 8:51 ` Jan Kara
2026-10-08 9:39 ` Christoph Hellwig
2026-10-02 9:23 ` Julian Sun
2026-10-05 8:27 ` Christoph Hellwig
2026-09-25 6:44 ` [PATCH v9 2/3] memcg,writeback: flush foreign bdev mappings separately from owner wbs Julian Sun
2026-09-25 6:55 ` Christoph Hellwig
2026-09-25 13:00 ` Julian Sun
2026-09-28 6:18 ` Christoph Hellwig
2026-09-25 6:44 ` [PATCH v9 3/3] writeback: add tracepoints for foreign bdev writeback Julian Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arYaMbJUh6unvz_t@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=sunjunchao@bytedance.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.