Re: [PATCH v7 23/24] drm/xe: add migrate ULLS period configfs attribute

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Sep 25, 2026 at 06:51:54AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] xe: format string mismatch for u32 configfs attribute
> --
> 
> commit 11e688bb0c4319099fe2944add90b93a411505ab
> Author: Matthew Brost <matthew.brost@intel.com>
> 
> drm/xe: add migrate ULLS period configfs attribute
> 
> This commit adds a configfs attribute to control the migrate ULLS period.
> The period specifies how long in milliseconds migrate ULLS remains active
> before exiting, primarily intended for performance tuning.
> 
> > diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
> > index f1555a9d31170..3f09dd17f80e0 100644
> > --- a/drivers/gpu/drm/xe/xe_configfs.c
> > +++ b/drivers/gpu/drm/xe/xe_configfs.c
> [ ... ]
> > @@ -631,6 +648,33 @@ static ssize_t enable_multi_queue_store(struct config_item *item, const char *pa
> >  	return len;
> >  }
> >  
> > +static ssize_t migrate_ulls_period_ms_show(struct config_item *item, char *page)
> > +{
> > +	struct xe_config_device *dev = to_xe_config_device(item);
> > +
> > +	return sprintf(page, "%d\n", dev->migrate_ulls_period_ms);
> 
> [Severity: Low]
> Since dev->migrate_ulls_period_ms is an unsigned 32-bit integer (u32),
> could writing a value greater than INT_MAX via configfs cause it to be read
> back as a negative number due to the "%d" format string?
> 
> Would "%u" be more appropriate here to preserve the read/write round-trip
> property for userspace?

Yes, %u is correct. Will fix.

Matt

> 
> > +}
> [ ... ]
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260925045320.1325860-1-matthew.brost@intel.com?part=23