From: Breno Leitao <leitao@debian.org>
To: "Björn Töpel" <bjorn@kernel.org>
Cc: Alexander Duyck <alexanderduyck@fb.com>,
Jakub Kicinski <kuba@kernel.org>,
kernel-team@meta.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Mohsin Bashir <mohsin.bashr@gmail.com>,
"Mike Marciniszyn (Meta)" <mike.marciniszyn@gmail.com>,
Simon Horman <horms@kernel.org>,
Mina Almasry <almasrymina@google.com>,
linux-kernel@vger.kernel.org,
Sashiko <netdev-bot+sashiko@kernel.org>
Subject: Re: [PATCH net v2] eth: fbnic: Keep real queue counts synchronized
Date: Fri, 25 Sep 2026 01:23:45 -0700 [thread overview]
Message-ID: <arYutH9Mvn3OzR8-@gmail.com> (raw)
In-Reply-To: <20260924191817.1843726-1-bjorn@kernel.org>
Hello Björn,
On Thu, Sep 24, 2026 at 09:18:15PM +0200, Björn Töpel wrote:
> If resume gets fewer vectors than the configured
> layout needs, fail with -ENOSPC rather than silently change the queue
> configuration and its bindings. The netdev then stays detached until a
> later recovery or a device reprobe.
I am a bit surprised that I is better to get the device permanetly
disconnected other than just getting it running with fewer queues on
resume.
What is reprobing it later?
> Fixes: da43127a8edc ("eth: fbnic: support queue ops / zero-copy Rx")
> Reported-by: Sashiko <netdev-bot+sashiko@kernel.org> Link:
> https://lore.kernel.org/netdev/178915061000.219967.7726187707862333281@kernel.org/
> Signed-off-by: Björn Töpel <bjorn@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
PS: The question above shouldn't block the merge of the patch, it is
just for my own curiosity.
next prev parent reply other threads:[~2026-09-25 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 19:18 [PATCH net v2] eth: fbnic: Keep real queue counts synchronized Björn Töpel
2026-09-25 8:23 ` Breno Leitao [this message]
2026-09-25 12:54 ` Björn Töpel
2026-09-25 19:18 ` netdev-bot+sashiko
2026-09-28 9:02 ` Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arYutH9Mvn3OzR8-@gmail.com \
--to=leitao@debian.org \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mike.marciniszyn@gmail.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.