From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 301AEC9830E for ; Fri, 25 Sep 2026 13:25:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xA5vS-0007GD-W1; Fri, 25 Sep 2026 09:25:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA5vQ-0007Fk-0D for qemu-devel@nongnu.org; Fri, 25 Sep 2026 09:25:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA5vO-0005fJ-GL for qemu-devel@nongnu.org; Fri, 25 Sep 2026 09:25:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790342713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KRhLp6vIz7t+Z+IxU2WvuYYKDqOYzyK5hpixaLn/Mvs=; b=FxRy8I1XqSfNoINhS26q26tZoYJGN1qXqiSqGibt5AlZyMPKX5CTqHuPX+uVT8dMyNuBid H4uaRTd28YB6p5EyK/8qiJWkst6xJYW+FIprvS7uj5VSrbOdNmA0RA+cxZ816DTqBH4Mvx 6rGM0pB8RA4Ag8/9FkTPoQ6UUmolzhA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-527-3l6bgs7_NAOKzajvejYkvA-1; Fri, 25 Sep 2026 09:25:09 -0400 X-MC-Unique: 3l6bgs7_NAOKzajvejYkvA-1 X-Mimecast-MFC-AGG-ID: 3l6bgs7_NAOKzajvejYkvA_1790342708 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F2AD0183091F; Fri, 25 Sep 2026 13:25:07 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.175]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4BF90766; Fri, 25 Sep 2026 13:25:05 +0000 (UTC) Date: Fri, 25 Sep 2026 15:25:02 +0200 From: Kevin Wolf To: Andrey Drobyshev Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, hreitz@redhat.com, vsementsov@yandex-team.ru, den@openvz.org Subject: Re: [PATCH v2] block: allocate aligned write buffer for 'truncate -m full' Message-ID: References: <20260923162224.34946-1-andrey.drobyshev@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260923162224.34946-1-andrey.drobyshev@virtuozzo.com> X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 23.09.2026 um 18:22 hat Andrey Drobyshev geschrieben: > In case we're truncating an image opened with O_DIRECT, we might get > -EINVAL on write with unaligned buffer. In particular, when running > iotests/298 with '-nocache' we get: > > qemu-io: Failed to resize underlying file: Could not write zeros for > preallocation: Invalid argument > > Let's just allocate the buffer using qemu_blockalign0() instead. > > Signed-off-by: Andrey Drobyshev > Reviewed-by: Denis V. Lunev > Reviewed-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin