From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CAB5C9830E for ; Fri, 25 Sep 2026 09:39:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xA2Of-0000SD-Kw; Fri, 25 Sep 2026 05:39:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA2Od-0000Qe-05 for qemu-devel@nongnu.org; Fri, 25 Sep 2026 05:39:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA2Oa-0006Fr-Ei for qemu-devel@nongnu.org; Fri, 25 Sep 2026 05:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790329146; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=b5Ty/VPfLSTWf2XnjdqDhYrewmOXjVlLili0rlMex2U=; b=JfF1RTcaB8EvCsgQymq3//b/b/aZ+pU9ISUuMvPxIVimo+Af/H9WULrdAM0Rqp6LnHCFQ6 xA/b3Ga2h6pxOv0Z6Rwez279JFu4qxtsim2XhX0liqHi3YpjzeLJ06l8+RZ7H+Ch/6D3yZ JJeUHgORMe+lSgBo8AOuqzGXvpUB3qQ= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-T-vCNhtwO5e19F38dye86g-1; Fri, 25 Sep 2026 05:39:02 -0400 X-MC-Unique: T-vCNhtwO5e19F38dye86g-1 X-Mimecast-MFC-AGG-ID: T-vCNhtwO5e19F38dye86g_1790329141 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9471B1955DBE; Fri, 25 Sep 2026 09:39:01 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CF2B841D; Fri, 25 Sep 2026 09:38:59 +0000 (UTC) Date: Fri, 25 Sep 2026 10:38:57 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 2/4] tests/tcg/meson.build: introduce cc_alt (alternative cross compiler) Message-ID: References: <20260924213942.26491-1-pierrick.bouvier@oss.qualcomm.com> <20260924213942.26491-3-pierrick.bouvier@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260924213942.26491-3-pierrick.bouvier@oss.qualcomm.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Sep 24, 2026 at 09:39:40PM +0000, Pierrick Bouvier wrote: > This allows each target to provide an additional list of cross > compilers to check. With this, we can detect default cc for common > setups (debian/fedora/macos) without user having to provide a > --cross-cc-* option. > > In addition, it allows us to pick up host compilers for various hosts. > (debian and archlinux have $arch-linux-gnu-gcc installed > with gcc package by default, but not fedora). > > Signed-off-by: Pierrick Bouvier > --- > tests/tcg/meson.build | 46 +++++++++++++++++++++++++------------------ > 1 file changed, 27 insertions(+), 19 deletions(-) > > diff --git a/tests/tcg/meson.build b/tests/tcg/meson.build > index 0006d192cab..59ab73e1d10 100644 > --- a/tests/tcg/meson.build > +++ b/tests/tcg/meson.build > @@ -21,6 +21,7 @@ tcg_tests = {} > # { > # 'name_of_target': { > # 'cc': 'cross_compiler', > +# 'cc_alt': ['list of alternative cross compilers', ...] > # 'cc_dockerfile': 'name_of_dockerfile', > # 'cc_feat_cflags': { > # 'name': ['feature cflags'], > @@ -210,7 +211,7 @@ foreach target, plan: tcg_tests > > # return a clear error if user misspell a target entry > foreach key, _ : plan > - allowed = ['cc', 'cc_dockerfile', 'cc_feat_cflags', > + allowed = ['cc', 'cc_alt', 'cc_dockerfile', 'cc_feat_cflags', > 'folder', 'gdb_arch', 'gdb_feat_version', 'qemu', 'tests'] > if key not in allowed > error('unknown tcg test plan entry \'' + key + '\' for target ' + target + > @@ -218,15 +219,18 @@ foreach target, plan: tcg_tests > endif > endforeach > > - cc = find_program(plan['cc'], required : false) > + cc_list = [plan['cc']] > + if 'cc_alt' in plan > + cc_list += plan['cc_alt'] > + endif If you're combining these into a list anyway, why not just have 'cc' be a list of CC names to begin with and not bother with a separate 'cc_alt' field ? > + > cc_cflags = [] > - > check_flags = [] > check_required = false > cross_cc = get_option('tcg_tests_cross_cc_' + cc_arch) > if cross_cc != '' > - # we make sure cross cc exists > - cc = find_program(cross_cc, required: true) > + # prepend requested cross_cc > + cc_list = [cross_cc, cc_list] > check_required = true > endif > cross_cflags = get_option('tcg_tests_cross_cflags_' + cc_arch) > @@ -236,22 +240,26 @@ foreach target, plan: tcg_tests > check_flags = cc_cflags > check_required = true > endif > - > - cc_from_system = cc.found() > - has_cc = cc.found() > - if has_cc > - if target.endswith('softmmu') > - check_flags += ['-nostdlib', '-ffreestanding', '-r'] > - else > - check_flags += ['-static'] > - endif > - > - cmd = run_command([cc, files('test_cc.c'), check_flags, '-o', '/dev/null'], > - check: check_required) > - has_cc = cmd.returncode() == 0 > - cc_from_system = has_cc > + if target.endswith('softmmu') > + check_flags += ['-nostdlib', '-ffreestanding', '-r'] > + else > + check_flags += ['-static'] > endif > > + has_cc = false > + foreach possible_cc: cc_list > + cc = find_program(possible_cc, required: check_required) > + if cc.found() > + cmd = run_command([cc, files('test_cc.c'), check_flags, '-o', '/dev/null'], > + check: check_required) > + if cmd.returncode() == 0 > + has_cc = true > + break > + endif > + endif > + endforeach > + > + cc_from_system = has_cc > build_test_depends = [] > build_test_depend_files = [] > > -- > 2.43.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|