From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tengda Wu <wutengda@huaweicloud.com>, Ian Rogers <irogers@google.com>
Cc: "Steinar H. Gunderson" <sesse@google.com>,
Namhyung Kim <namhyung@kernel.org>,
james.clark@linaro.org, xueshuai@linux.alibaba.com,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
leo.yan@linux.dev, Li Huafei <lihuafei1@huawei.com>,
Kim Phillips <kim.phillips@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>, Bill Wendling <morbo@google.com>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Zecheng Li <zli94@ncsu.edu>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] perf llvm: Fix memory leak of args->fileloc in symbol__disassemble_llvm()
Date: Fri, 25 Sep 2026 11:59:24 +0200 [thread overview]
Message-ID: <arZF_Mphl3Rim0Gw@x2> (raw)
In-Reply-To: <arZFMCzEiHbTL6IK@x2>
On Fri, Sep 25, 2026 at 11:56:04AM +0200, Arnaldo Carvalho de Melo wrote:
> On Mon, Sep 21, 2026 at 11:36:08AM -0700, Ian Rogers wrote:
> > On Thu, Sep 17, 2026 at 5:58 AM Tengda Wu <wutengda@huaweicloud.com> wrote:
> > > In symbol__disassemble_llvm(), after calling llvm_addr2line(), if the
> > > subsequent disasm_line__new() fails, the code directly jumps to 'err'
> > > without freeing args->fileloc, leading to a memory leak.
>
> > > Fix this by explicitly calling free(args->fileloc) before jumping to
> > > the error handling path when disasm_line__new() fails.
>
> > > Fixes: 048856817888 ("perf annotate: LLVM-based disassembler")
> > > Signed-off-by: Tengda Wu <wutengda@huaweicloud.com>
>
> > Reviewed-by: Ian Rogers <irogers@google.com>
>
> I replaced the free() with a zfree(&), minor.
I understand why you didn't use zfree(), to make it consistent with the
other free, will keep it and leave the zfree() for later.
Sorry about the noise,
- Arnaldo
next prev parent reply other threads:[~2026-09-25 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 12:58 [PATCH] perf llvm: Fix memory leak of args->fileloc in symbol__disassemble_llvm() Tengda Wu
2026-09-17 13:07 ` sashiko-bot
2026-09-21 18:36 ` Ian Rogers
2026-09-25 9:56 ` Arnaldo Carvalho de Melo
2026-09-25 9:59 ` Arnaldo Carvalho de Melo [this message]
2026-09-28 0:54 ` Tengda Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arZF_Mphl3Rim0Gw@x2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=kim.phillips@arm.com \
--cc=leo.yan@linux.dev \
--cc=lihuafei1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=peterz@infradead.org \
--cc=sesse@google.com \
--cc=wutengda@huaweicloud.com \
--cc=xueshuai@linux.alibaba.com \
--cc=zli94@ncsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.