From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [RFC PATCH 03/14] qemu-options: Consolidate branches in opts_parse
Date: Fri, 25 Sep 2026 11:07:27 +0100 [thread overview]
Message-ID: <arZH3xM9i3EPK__y@redhat.com> (raw)
In-Reply-To: <20260918223002.1892021-4-farosas@suse.de>
On Fri, Sep 18, 2026 at 07:29:50PM -0300, Fabiano Rosas wrote:
> The two branches that return NULL can be put under a single branch
> because the qemu_opts_del function can take a NULL opt. The next patch
> will add common cleanup code to the error path so change this now to
> avoid code duplication.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> util/qemu-option.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-09-25 10:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 22:29 [RFC PATCH 00/14] qemu-options: Remove some complexity Fabiano Rosas
2026-09-18 22:29 ` [RFC PATCH 01/14] meson: Fix meson suites invocation from make check Fabiano Rosas
2026-09-25 12:14 ` Fabiano Rosas
2026-09-18 22:29 ` [RFC PATCH 02/14] qemu-options: Use g_autofree when calling get_opt_name_value() Fabiano Rosas
2026-09-25 10:05 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 03/14] qemu-options: Consolidate branches in opts_parse Fabiano Rosas
2026-09-25 10:07 ` Daniel P. Berrangé [this message]
2026-09-18 22:29 ` [RFC PATCH 04/14] qemu-options: Add qemu_opts_parse_list Fabiano Rosas
2026-09-25 10:14 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 05/14] qemu-options: Change qemu_parse_opts() to take the group name Fabiano Rosas
2026-09-25 10:11 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 06/14] qemu-options: Call qemu_opts_print_help() one level down Fabiano Rosas
2026-09-25 10:15 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 07/14] qemu-options: Consolidate qemu_opts_parse* functions Fabiano Rosas
2026-09-25 10:21 ` Daniel P. Berrangé
2026-09-25 12:21 ` Fabiano Rosas
2026-09-28 10:41 ` Daniel P. Berrangé
2026-09-28 14:52 ` Fabiano Rosas
2026-09-18 22:29 ` [RFC PATCH 08/14] qemu-options: Add qemu_opts_parse_list_noisily Fabiano Rosas
2026-09-25 10:25 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 09/14] qemu-options: Change qemu_opts_parse_noisily() to take the group Fabiano Rosas
2026-09-21 13:51 ` Stefan Hajnoczi
2026-09-25 10:27 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 10/14] qemu-options: Check for NULL list at qemu_opts_parse() Fabiano Rosas
2026-09-25 10:28 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 11/14] qemu-options: pass an Error into get_opt_name_value Fabiano Rosas
2026-09-25 10:35 ` Daniel P. Berrangé
2026-09-18 22:29 ` [RFC PATCH 12/14] qemu-options: merge warn and help flags Fabiano Rosas
2026-09-18 22:30 ` [RFC PATCH 13/14] qemu-options: Further simplify qemu_opts_parse_list() Fabiano Rosas
2026-09-18 22:30 ` [RFC PATCH 14/14] qemu-options: Remove opts_parse() Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arZH3xM9i3EPK__y@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.