From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0211BC9830E for ; Fri, 25 Sep 2026 10:12:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xA2u3-0007YY-OP; Fri, 25 Sep 2026 06:11:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA2u2-0007YO-Vv for qemu-devel@nongnu.org; Fri, 25 Sep 2026 06:11:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA2u1-0000ez-7O for qemu-devel@nongnu.org; Fri, 25 Sep 2026 06:11:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790331095; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgcoTU1cf9FTfuBse1SUG3f6Oj4n4O8WrqLqpX8OoI4=; b=Jkl47u2ZMzGfxwpbsPS6mbL3i64cPFVIWTLqofvhPQoPxFjdT1Z47Eso1ny9gmkD0VFJBF XPHFbwQJpj94G9Ndi9HKykgax620JppzCtPNPasHa8AuJ+Lek23HafKN9cJrs++1J/c+JX 3HCdBDd4pFgoIQWPoL+v4MsiFexdkho= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-lnq0eXGoM0qAxoKo2OGY8A-1; Fri, 25 Sep 2026 06:11:32 -0400 X-MC-Unique: lnq0eXGoM0qAxoKo2OGY8A-1 X-Mimecast-MFC-AGG-ID: lnq0eXGoM0qAxoKo2OGY8A_1790331091 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED7A41956077; Fri, 25 Sep 2026 10:11:30 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 756EF1800473; Fri, 25 Sep 2026 10:11:29 +0000 (UTC) Date: Fri, 25 Sep 2026 11:11:26 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Michael Roth Subject: Re: [RFC PATCH 05/14] qemu-options: Change qemu_parse_opts() to take the group name Message-ID: References: <20260918223002.1892021-1-farosas@suse.de> <20260918223002.1892021-6-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260918223002.1892021-6-farosas@suse.de> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 18, 2026 at 07:29:52PM -0300, Fabiano Rosas wrote: > Get rid of the pattern qemu_parse_opts(qemu_find_opts("some-opt")) by > passing the string directly to qemu_parse_opts(). > > Don't check for NULL list at this time to preserve the old behavior. A > subsequent patch will correct that. > > Signed-off-by: Fabiano Rosas > --- > include/qemu/option.h | 2 +- > system/vl.c | 5 ++--- > tests/unit/test-opts-visitor.c | 12 ++++-------- > util/qemu-option.c | 19 +++++++++++-------- > 4 files changed, 18 insertions(+), 20 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|