From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDCA7C9830D for ; Fri, 25 Sep 2026 10:28:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xA39v-0002a8-3Y; Fri, 25 Sep 2026 06:28:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA39u-0002Zq-7M for qemu-devel@nongnu.org; Fri, 25 Sep 2026 06:28:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA39s-000288-DE for qemu-devel@nongnu.org; Fri, 25 Sep 2026 06:28:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790332079; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+ZD9RYJmfl5kKB/ENEqcD916+6MBeduFwwlnnXJbvQ=; b=ZT7h2TzxsjsyfzLiUUTjHbe8g14ZVmDLjRAEbUExXFb2TQAbt8sWn7XtOlcAMWEqb+7oMY OJa8e/yxw0UvvTem9ZEH9CRzDHrNpVtuPlUslsbQqf2nYPEuaFhfY514571IrnyzBkNAdr gI3aazJOYHX/2cb30YEuZHd9rYpI8Co= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-452-kHKflOcYOZWMGVv74hP04Q-1; Fri, 25 Sep 2026 06:27:54 -0400 X-MC-Unique: kHKflOcYOZWMGVv74hP04Q-1 X-Mimecast-MFC-AGG-ID: kHKflOcYOZWMGVv74hP04Q_1790332067 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D75CF1953986; Fri, 25 Sep 2026 10:27:46 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C1651956086; Fri, 25 Sep 2026 10:27:43 +0000 (UTC) Date: Fri, 25 Sep 2026 11:27:40 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Markus Armbruster , Kevin Wolf , Hanna Reitz , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , Pierrick Bouvier , Alexandre Iooss , Stefan Hajnoczi Subject: Re: [RFC PATCH 09/14] qemu-options: Change qemu_opts_parse_noisily() to take the group Message-ID: References: <20260918223002.1892021-1-farosas@suse.de> <20260918223002.1892021-10-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260918223002.1892021-10-farosas@suse.de> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 18, 2026 at 07:29:56PM -0300, Fabiano Rosas wrote: > Pass the group name as argument to qemu_opts_parse_noisily() to make > it simmetric with qemu_opts_parse(). > > This change solves the issue of qemu_opts_parse_noisily() crashing on > a NULL return from qemu_find_opts(), which can happen when an option > is invoked for code in a module that is not loaded. > > Signed-off-by: Fabiano Rosas > --- > block/monitor/block-hmp-cmds.c | 2 +- > blockdev.c | 2 +- > chardev/char-hmp-cmds.c | 5 +-- > include/qemu/option.h | 2 +- > plugins/loader.c | 2 +- > qemu-img.c | 3 +- > semihosting/config.c | 4 +- > system/vl.c | 75 ++++++++++++---------------------- > tests/unit/test-char.c | 12 ++---- > tests/unit/test-seccomp.c | 6 +-- > trace/control.c | 3 +- > ui/vnc.c | 3 +- > util/qemu-option.c | 14 ++++++- > 13 files changed, 54 insertions(+), 79 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|