From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A871C9830D for ; Fri, 25 Sep 2026 10:35:58 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xA3H4-0004Oy-Gm; Fri, 25 Sep 2026 06:35:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA3H2-0004Oj-Py for qemu-devel@nongnu.org; Fri, 25 Sep 2026 06:35:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA3Gy-0002uy-LX for qemu-devel@nongnu.org; Fri, 25 Sep 2026 06:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790332515; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=urB1BI8Y2E/Tsyti5SJ4J+ACeU8SEFqeJ0saQ9OTnJ4=; b=G0B4CeH6ArMEj5I0WvifLxTI9h5yQ5RA36En3GUQZN3fANQAYElYTO36aeaLlBmQcSobhM cix/o0lhPzmVeu1l7s18tcbqle7Jo5DMZMHr0yaq+tL7PNslwQnExDfeaDF1EILBNLlp3u RqsUiVP83RghlRX3g7bB14j06Ta8/Eo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-608-PKioI002NmCSvslN-hMs4g-1; Fri, 25 Sep 2026 06:35:12 -0400 X-MC-Unique: PKioI002NmCSvslN-hMs4g-1 X-Mimecast-MFC-AGG-ID: PKioI002NmCSvslN-hMs4g_1790332511 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2D84319560BC; Fri, 25 Sep 2026 10:35:11 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ECF221956047; Fri, 25 Sep 2026 10:35:09 +0000 (UTC) Date: Fri, 25 Sep 2026 11:35:07 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Markus Armbruster Subject: Re: [RFC PATCH 11/14] qemu-options: pass an Error into get_opt_name_value Message-ID: References: <20260918223002.1892021-1-farosas@suse.de> <20260918223002.1892021-12-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260918223002.1892021-12-farosas@suse.de> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Sep 18, 2026 at 07:29:58PM -0300, Fabiano Rosas wrote: > Passing a boolean into get_opt_name_value() is to put too much > responsibility into this low-level routine. Have it just fill an Error > object and let the caller decide what to do with it. Setting an Error > is an easily recognizable pattern so it saves the reader from mentally > parsing the boolean logic. > > Signed-off-by: Fabiano Rosas > --- > util/qemu-option.c | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/util/qemu-option.c b/util/qemu-option.c > index 37e6d68f02..94e06b194d 100644 > --- a/util/qemu-option.c > +++ b/util/qemu-option.c > @@ -756,9 +756,9 @@ void qemu_opts_print(QemuOpts *opts, const char *separator) > > static const char *get_opt_name_value(const char *params, > const char *firstname, > - bool warn_on_flag, > bool *help_wanted, > - char **name, char **value) > + char **name, char **value, > + Error **errp) > { > const char *p; > const char *prefix = ""; > @@ -783,13 +783,15 @@ static const char *get_opt_name_value(const char *params, > *value = g_strdup("on"); > is_help = is_help_option(*name); > } > - if (!is_help && warn_on_flag) { > - warn_report("short-form boolean option '%s%s' deprecated", prefix, *name); > + if (!is_help) { > if (g_str_equal(*name, "delay")) { > - error_printf("Please use nodelay=%s instead\n", prefix[0] ? "on" : "off"); > + error_setg(errp, "Please use nodelay=%s instead", > + prefix[0] ? "on" : "off"); > } else { > - error_printf("Please use %s=%s instead\n", *name, *value); > + error_setg(errp, "Please use %s=%s instead", *name, *value); > } > + error_prepend(errp, "short-form boolean option '%s%s' " > + "deprecated", prefix, *name); > } > } We've had short form bool options deprecated for years now. I'd be inclined to follow through on the deprecation and delete support for short form bools now. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|