From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] perf: remove unused empty help-unknown-cmd.h header
Date: Fri, 25 Sep 2026 13:06:31 +0200 [thread overview]
Message-ID: <arZVt6gDYTJkaTBH@x2> (raw)
In-Reply-To: <CAP-5=fWS6TOnfq2WmJ_HOhkySF8XRQf92Zo2XhZSFJVv8XFSWw@mail.gmail.com>
On Thu, Sep 17, 2026 at 10:12:44PM -0700, Ian Rogers wrote:
> On Thu, Sep 17, 2026 at 8:24 PM Ethan Nelson-Moore
> <enelsonmoore@gmail.com> wrote:
> >
> > tools/perf/util/help-unknown-cmd.h has been empty and unused ever since
> > it was added to the kernel in commit 5feaac248a46 ("perf tools: Move
> > help_unknown_cmd() to its own file"). Remove it.
> >
> > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
>
> This seems like an accident, the declaration has been in
> tools/perf/builtin.h ever since the commit above. Perhaps the header
> file is a more natural location, but an empty header file is clearly
> useless.
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
prev parent reply other threads:[~2026-09-25 11:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 3:23 [PATCH] perf: remove unused empty help-unknown-cmd.h header Ethan Nelson-Moore
2026-09-18 3:26 ` sashiko-bot
2026-09-18 5:12 ` Ian Rogers
2026-09-25 11:06 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arZVt6gDYTJkaTBH@x2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=enelsonmoore@gmail.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.