From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Hajime Tazaki <thehajime@gmail.com>
Cc: akpm@linux-foundation.org, tasos.papagiannnis@gmail.com,
linux-mm@kvack.org, liam@infradead.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/nommu: Reject wrapping ranges in access_remote_vm()
Date: Fri, 25 Sep 2026 14:08:58 +0100 [thread overview]
Message-ID: <arZwZYUNmUUaoJmW@gremlin> (raw)
In-Reply-To: <m2cxum423s.wl-thehajime@gmail.com>
On Thu, Sep 10, 2026 at 05:11:03AM +0900, Hajime Tazaki wrote:
>
> Hello,
>
> On Wed, 09 Sep 2026 16:13:41 +0900,
> Andrew Morton wrote:
> >
> > On Wed, 9 Sep 2026 09:42:31 +0300 Anastasios Papagiannis <tasos.papagiannnis@gmail.com> wrote:
> >
> > > The NOMMU implementation of access_process_vm() rejects address ranges
> > > whose end wraps around, but access_remote_vm() bypasses this check even
> > > though both functions delegate to __access_remote_vm().
> > >
> > > Move the wraparound check into __access_remote_vm() so it applies to
> > > both entry points.
> >
> > lgtm, thanks.
> >
> > > This is originally reported in [1].
> > >
> > > [1] https://lore.kernel.org/bpf/4ef240a5bea36ff84df9589671367832860795159386a4c8fba546a0fa8b786f@mail.kernel.org/
> >
> > Ah, bpfbot scored one.
> >
> > Sashiko might have found more issues in there:
> > https://sashiko.dev/#/patchset/20260909064231.18693-1-tasos.papagiannnis@gmail.com
> >
> > I'll optimistically cc Hajime Tazaki, who has been doing some NOMMU
> > work recently.
>
> I got a similar review (from Sashiko) that current use of
> !vma->vm_file isn't appropriate and should use vma_set_anonymous(). IIUC
> that case happens only (I may miss something) with /dev/zero (via
> mmap_zero_prepare()).
That's no longer an issue as MAP_PRIVATE-/dev/zero is truly anon now.
>
> I also had a patch but am currently waiting for Lorenzo's input for
> his work on /dev/zero, which mentioned in his reply.
Sorry, I just added a script to find call outs in neomutt :)
As above.
>
> https://lore.kernel.org/linux-mm/an8BlTgk7sc5vFJ1@lucifer/
>
> Thus 3 comments of Sashiko (all about vma->vm_file) can be addressed
> in future, and are not needed an immediate fix.
You can use vma_is_anonymous() now.
>
> I wish to ask this to Lorenzo too.
>
> -- Hajime
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-09-25 13:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 6:42 [PATCH] mm/nommu: Reject wrapping ranges in access_remote_vm() Anastasios Papagiannis
2026-09-09 6:57 ` sashiko-bot
2026-09-09 7:13 ` Andrew Morton
2026-09-09 20:11 ` Hajime Tazaki
2026-09-25 13:08 ` Lorenzo Stoakes (ARM) [this message]
2026-09-25 13:20 ` Lorenzo Stoakes (ARM)
2026-09-25 23:04 ` Andrew Morton
2026-09-28 15:04 ` Anastasios Papagiannis
2026-09-28 15:07 ` Lorenzo Stoakes (ARM)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arZwZYUNmUUaoJmW@gremlin \
--to=ljs@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bpf@vger.kernel.org \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tasos.papagiannnis@gmail.com \
--cc=thehajime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.