From: Bjorn Andersson <andersson@kernel.org>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Fix USB interrupts in Glymur DT
Date: Fri, 25 Sep 2026 13:20:49 -0500 [thread overview]
Message-ID: <ara7cNuOCghH2p9m@zenbook> (raw)
In-Reply-To: <20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com>
On Mon, Aug 03, 2026 at 09:56:03AM +0530, Krishna Kurapati wrote:
> In Glymur, DRD capable USB Nodes are missing the HS Phy IRQ. Also, fix the
> pwr_event and hs_phy interrupt numbers in Multiport coontroller node.
>
> While at it, the dp and dm interrupt numbers have been swapped on HS only
> usb controller. Fix them up.
>
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> This series has only been compile tested.
>
> Binding depedency:
> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
Please resend when this binding has landed.
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/glymur.dtsi | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index f04058d2e089..7a71297db481 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> @@ -4574,11 +4574,13 @@ usb_0: usb@a600000 {
>
> interrupts-extended = <&intc GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 368 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 90 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 60 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 17 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "dwc_usb3",
> "pwr_event",
> + "hs_phy_irq",
> "dp_hs_phy_irq",
> "dm_hs_phy_irq",
> "ss_phy_irq";
> @@ -4649,11 +4651,13 @@ usb_1: usb@a800000 {
>
> interrupts-extended = <&intc GIC_SPI 875 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 369 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 878 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 88 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 87 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 76 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "dwc_usb3",
> "pwr_event",
> + "hs_phy_irq",
> "dp_hs_phy_irq",
> "dm_hs_phy_irq",
> "ss_phy_irq";
> @@ -4725,11 +4729,13 @@ usb_2: usb@a000000 {
>
> interrupts-extended = <&intc GIC_SPI 871 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 877 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 89 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 81 IRQ_TYPE_EDGE_BOTH>,
> <&pdc 75 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "dwc_usb3",
> "pwr_event",
> + "hs_phy_irq",
> "dp_hs_phy_irq",
> "dm_hs_phy_irq",
> "ss_phy_irq";
> @@ -4805,14 +4811,14 @@ usb_hs: usb@a200000 {
>
> interrupts-extended = <&intc GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>,
> <&intc GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>,
> - <&pdc 92 IRQ_TYPE_EDGE_BOTH>,
> + <&intc GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 57 IRQ_TYPE_EDGE_BOTH>,
> - <&intc GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH>;
> + <&pdc 92 IRQ_TYPE_EDGE_BOTH>;
> interrupt-names = "dwc_usb3",
> "pwr_event",
> + "hs_phy_irq",
> "dp_hs_phy_irq",
> - "dm_hs_phy_irq",
> - "hs_phy_irq";
> + "dm_hs_phy_irq";
>
> resets = <&gcc GCC_USB20_PRIM_BCR>;
>
> @@ -4870,10 +4876,10 @@ usb_mp: usb@a400000 {
> "noc_aggr_south";
>
> interrupts-extended = <&intc GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>,
> - <&intc GIC_SPI 345 IRQ_TYPE_LEVEL_HIGH>,
> - <&intc GIC_SPI 346 IRQ_TYPE_LEVEL_HIGH>,
> - <&intc GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
> - <&intc GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 313 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 314 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 130 IRQ_TYPE_LEVEL_HIGH>,
> + <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 12 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 11 IRQ_TYPE_LEVEL_HIGH>,
> <&pdc 14 IRQ_TYPE_LEVEL_HIGH>,
>
> ---
> base-commit: 1e88112e60de707020f3def45af81f9a0180ee82
> change-id: 20260803-glymur-dt-usb-fixes-62f314d3f3a9
>
> Best regards,
> --
> Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>
prev parent reply other threads:[~2026-09-25 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 4:26 [PATCH] arm64: dts: qcom: Fix USB interrupts in Glymur DT Krishna Kurapati
2026-08-18 13:46 ` Konrad Dybcio
2026-09-25 18:20 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ara7cNuOCghH2p9m@zenbook \
--to=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.