From: Jarkko Sakkinen <jarkko@kernel.org>
To: lijun <lijun01@kylinos.cn>
Cc: oe-kbuild-all@lists.linux.dev, kernel test robot <lkp@intel.com>
Subject: Re: [linux-next:master 7478/8449] drivers/char/tpm/tpm_tis.c:249:61: error: 'tpm_tis_resume' undeclared here (not in a function); did you mean 'tpm_tis_remove'?
Date: Fri, 25 Sep 2026 17:47:06 +0300 [thread overview]
Message-ID: <araJahBUUtwlLlUk@kernel.org> (raw)
In-Reply-To: <a7ba40bc-77f5-44f0-935e-16b9a6f5cb48@kylinos.cn>
On Tue, Sep 22, 2026 at 09:24:54AM +0800, lijun wrote:
> I am sorry , the compilation issue was caused by my mistake.
>
> and should we merge the fix patch and the original patch into one patch,
>
> [PATCH v3] tpm: use DEFINE_SIMPLE_DEV_PM_OPS and pm_sleep_ptr().
>
> 2026/9/21 21:13, kernel test robot :
> > tree:https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 3f2425f5b5bbbdd991ca9cdfd5502e68d8895998
> > commit: 69178fc202218a6da564f02dc5a2630dadbb7bf8 [7478/8449] tpm: use DEFINE_SIMPLE_DEV_PM_OPS and pm_sleep_ptr()
> > config: x86_64-randconfig-2005-20250721 (https://download.01.org/0day-ci/archive/20260921/202609211540.IJG9MjgJ-lkp@intel.com/config)
> > compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260921/202609211540.IJG9MjgJ-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot<lkp@intel.com>
> > | Closes:https://lore.kernel.org/oe-kbuild-all/202609211540.IJG9MjgJ-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > In file included from include/linux/kernel.h:35,
> > from include/linux/random.h:7,
> > from include/linux/nodemask.h:94,
> > from include/linux/numa.h:6,
> > from include/linux/cpumask.h:15,
> > from arch/x86/include/asm/paravirt.h:19,
> > from arch/x86/include/asm/irqflags.h:100,
> > from include/linux/irqflags.h:18,
> > from arch/x86/include/asm/special_insns.h:10,
> > from arch/x86/include/asm/processor.h:25,
> > from arch/x86/include/asm/timex.h:5,
> > from include/linux/timex.h:67,
> > from include/linux/time32.h:13,
> > from include/linux/time.h:60,
> > from include/linux/stat.h:19,
> > from include/linux/module.h:13,
> > from drivers/char/tpm/tpm_tis.c:19:
> > > > drivers/char/tpm/tpm_tis.c:249:61: error: 'tpm_tis_resume' undeclared here (not in a function); did you mean 'tpm_tis_remove'?
> > 249 | static DEFINE_SIMPLE_DEV_PM_OPS(tpm_tis_pm, tpm_pm_suspend, tpm_tis_resume);
> > | ^~~~~~~~~~~~~~
> > include/linux/util_macros.h:136:44: note: in definition of macro 'PTR_IF'
> > 136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
> > | ^~~
> > include/linux/pm.h:316:19: note: in expansion of macro 'pm_sleep_ptr'
> > 316 | .resume = pm_sleep_ptr(resume_fn), \
> > | ^~~~~~~~~~~~
> > include/linux/pm.h:375:9: note: in expansion of macro 'SYSTEM_SLEEP_PM_OPS'
> > 375 | SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
> > | ^~~~~~~~~~~~~~~~~~~
> > include/linux/pm.h:417:9: note: in expansion of macro '_DEFINE_DEV_PM_OPS'
> > 417 | _DEFINE_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL, NULL)
> > | ^~~~~~~~~~~~~~~~~~
> > drivers/char/tpm/tpm_tis.c:249:8: note: in expansion of macro 'DEFINE_SIMPLE_DEV_PM_OPS'
> > 249 | static DEFINE_SIMPLE_DEV_PM_OPS(tpm_tis_pm, tpm_pm_suspend, tpm_tis_resume);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > --
> > In file included from include/linux/kernel.h:35,
> > from include/linux/random.h:7,
> > from include/linux/nodemask.h:94,
> > from include/linux/numa.h:6,
> > from include/linux/cpumask.h:15,
> > from arch/x86/include/asm/paravirt.h:19,
> > from arch/x86/include/asm/irqflags.h:100,
> > from include/linux/irqflags.h:18,
> > from arch/x86/include/asm/special_insns.h:10,
> > from arch/x86/include/asm/processor.h:25,
> > from include/linux/sched.h:13,
> > from include/linux/ratelimit.h:6,
> > from include/linux/dev_printk.h:16,
> > from include/linux/device.h:15,
> > from include/linux/pnp.h:12,
> > from drivers/char/tpm/tpm_infineon.c:15:
> > > > drivers/char/tpm/tpm_infineon.c:615:61: error: 'tpm_inf_resume' undeclared here (not in a function); did you mean 'tpm_pm_resume'?
> > 615 | static DEFINE_SIMPLE_DEV_PM_OPS(tpm_inf_pm, tpm_pm_suspend, tpm_inf_resume);
> > | ^~~~~~~~~~~~~~
> > include/linux/util_macros.h:136:44: note: in definition of macro 'PTR_IF'
> > 136 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL)
> > | ^~~
> > include/linux/pm.h:316:19: note: in expansion of macro 'pm_sleep_ptr'
> > 316 | .resume = pm_sleep_ptr(resume_fn), \
> > | ^~~~~~~~~~~~
> > include/linux/pm.h:375:9: note: in expansion of macro 'SYSTEM_SLEEP_PM_OPS'
> > 375 | SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) \
> > | ^~~~~~~~~~~~~~~~~~~
> > include/linux/pm.h:417:9: note: in expansion of macro '_DEFINE_DEV_PM_OPS'
> > 417 | _DEFINE_DEV_PM_OPS(name, suspend_fn, resume_fn, NULL, NULL, NULL)
> > | ^~~~~~~~~~~~~~~~~~
> > drivers/char/tpm/tpm_infineon.c:615:8: note: in expansion of macro 'DEFINE_SIMPLE_DEV_PM_OPS'
> > 615 | static DEFINE_SIMPLE_DEV_PM_OPS(tpm_inf_pm, tpm_pm_suspend, tpm_inf_resume);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> >
> > vim +249 drivers/char/tpm/tpm_tis.c
> >
> > 248
> > > 249 static DEFINE_SIMPLE_DEV_PM_OPS(tpm_tis_pm, tpm_pm_suspend, tpm_tis_resume);
> > 250
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
Please sanity check the commit with squashed fixes from my tree.
Br, Jarkko
next prev parent reply other threads:[~2026-09-25 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 13:13 [linux-next:master 7478/8449] drivers/char/tpm/tpm_tis.c:249:61: error: 'tpm_tis_resume' undeclared here (not in a function); did you mean 'tpm_tis_remove'? kernel test robot
2026-09-22 1:24 ` lijun
2026-09-25 14:47 ` Jarkko Sakkinen [this message]
2026-10-12 2:46 ` lijun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=araJahBUUtwlLlUk@kernel.org \
--to=jarkko@kernel.org \
--cc=lijun01@kylinos.cn \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.