From: Breno Leitao <leitao@debian.org>
To: Zack Gomez <zack.gomez@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, stephen@networkplumber.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] netpoll: bound the deferred transmit queue
Date: Fri, 25 Sep 2026 08:32:56 -0700 [thread overview]
Message-ID: <araTwjYJRMlfd2PX@gmail.com> (raw)
In-Reply-To: <20260923181111.1182838-1-zack.gomez@gmail.com>
On Wed, Sep 23, 2026 at 02:11:11PM -0400, Zack Gomez wrote:
> __netpoll_send_skb() parks an skb on npinfo->txq whenever the device
> cannot take it at once, and once the queue is non-empty every later skb
> goes straight there to keep ordering. queue_process() drains it from a
> workqueue and, unlike the direct path, never polls the device for
> completions: when the ring is stopped it backs off HZ/10. Nothing limits
> the queue length.
...
> Fixes: b6cd27ed3388 ("netpoll per device txq")
I don't think this should be a fix, honestly. I would prefer to see this
on net-next without the Fixes tag.
> Assisted-by: Claude:claude-fable-5-1
> Signed-off-by: Zack Gomez <zack.gomez@gmail.com>
Reviewed-by: Breno Leitao <leitao@debian.org>
next prev parent reply other threads:[~2026-09-25 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 18:11 [PATCH net v3] netpoll: bound the deferred transmit queue Zack Gomez
2026-09-25 15:32 ` Breno Leitao [this message]
2026-09-25 20:19 ` Zack Gomez
2026-09-27 18:01 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=araTwjYJRMlfd2PX@gmail.com \
--to=leitao@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=zack.gomez@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.