All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name
Date: Fri, 25 Sep 2026 08:35:43 -0700	[thread overview]
Message-ID: <araUzxox2c-e_pOA@z2> (raw)
In-Reply-To: <20260917061312.820074-1-irogers@google.com>

On Wed, Sep 16, 2026 at 11:13:12PM -0700, Ian Rogers wrote:
> The grep to match cgroup name in metric output assumes no leading / on
> the cgroup name, however, cgroups in /proc/self/cgroup may have a
> leading /. Strip the / if it exists to avoid failures to match the
> cgroup name in the perf stat output.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
>  tools/perf/tests/shell/stat_metrics_cgrp.sh | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/stat_metrics_cgrp.sh b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> index d4226ee0ae98..0728f48f21fa 100755
> --- a/tools/perf/tests/shell/stat_metrics_cgrp.sh
> +++ b/tools/perf/tests/shell/stat_metrics_cgrp.sh
> @@ -86,6 +86,13 @@ check_metric_reported()
>  
>  	for cgrp in "${cgrps[@]}"; do
>  		# Find metric lines for this cgroup
> +		case "$cgrp" in
> +			/)  # The root cgroup, leave unchanged.
> +			  ;;
> +			/*) # Strip any starting slashes.
> +			  cgrp="${cgrp#/}"
> +			  ;;
> +		esac
>  		# We use exact cgroup match with surrounding commas
>  		local cgrp_lines
>  		cgrp_lines=$(echo "${output}" | grep -F ",${cgrp}," | grep "insn_per_cycle" || true)
> -- 
> 2.55.0.1082.g2b9226bbc0-goog
> 

      parent reply	other threads:[~2026-09-25 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  6:13 [PATCH v1] perf test: stat metrics cgroup strip possible slash from cgroup name Ian Rogers
2026-09-17  6:16 ` sashiko-bot
2026-09-25 15:33 ` Ian Rogers
2026-09-25 15:39   ` Arnaldo Carvalho de Melo
2026-09-25 15:35 ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=araUzxox2c-e_pOA@z2 \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.