From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF944C9830E for ; Fri, 25 Sep 2026 16:03:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xA8OP-0003r1-RA; Fri, 25 Sep 2026 12:03:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA8NT-00038b-Je for qemu-devel@nongnu.org; Fri, 25 Sep 2026 12:02:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xA8NR-00075H-0y for qemu-devel@nongnu.org; Fri, 25 Sep 2026 12:02:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790352140; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KoE2DZtzRKmRWLlrTBNICflrWg8wQZBG6EA9Pq0epZg=; b=JbkYOo+Pff3RdoEGJmRQExdG9BJBm1+6YRjaQshM/zYMLLE6r8tz+sq6giApvrdGbIUsuD KEMMKNQ2ZAKzq1jmrZi1ptOWIV8+ATVm1Ap7/s65lulJ/2wdIjFio10oSJYD8p7NrlgsO/ gpxI2b3MVFXG3yViEiVCc1riroRjREI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-W4zMTZEoNlSMT6itEgJf_w-1; Fri, 25 Sep 2026 12:02:15 -0400 X-MC-Unique: W4zMTZEoNlSMT6itEgJf_w-1 X-Mimecast-MFC-AGG-ID: W4zMTZEoNlSMT6itEgJf_w_1790352134 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1CC2518BAA01; Fri, 25 Sep 2026 16:02:14 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E1E11800473; Fri, 25 Sep 2026 16:02:12 +0000 (UTC) Date: Fri, 25 Sep 2026 17:02:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 1/4] tests/tcg/meson.build: report correct cc in summary Message-ID: References: <20260924213942.26491-1-pierrick.bouvier@oss.qualcomm.com> <20260924213942.26491-2-pierrick.bouvier@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260924213942.26491-2-pierrick.bouvier@oss.qualcomm.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Sep 24, 2026 at 09:39:39PM +0000, Pierrick Bouvier wrote: > Summary didn't consider that cc could have been set using --cross-cc* > options, and was wrongly reporting default cc declared in test suite. > Fix that by reporting path of compiler found. > > Signed-off-by: Pierrick Bouvier > --- > tests/tcg/meson.build | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tests/tcg/meson.build b/tests/tcg/meson.build > index 474e4d8f6e3..0006d192cab 100644 > --- a/tests/tcg/meson.build > +++ b/tests/tcg/meson.build > @@ -292,9 +292,10 @@ foreach target, plan: tcg_tests > > summary_cc = false > if has_cc > - summary_cc = plan['cc'] > - if not cc_from_system > - summary_cc += ' (from \'qemu/' + plan['cc_dockerfile'] + '\' container)' > + if cc_from_system > + summary_cc = cc.full_path() > + else > + summary_cc = plan['cc'] + ' (from \'qemu/' + plan['cc_dockerfile'] + '\' container)' > endif > endif > tcg_tests_summary += {'cc for ' + target: summary_cc} Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|