From: "Roger Pau Monné" <roger@xenproject.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Teddy Astie <teddy.astie@vates.tech>
Subject: Re: [PATCH 5/6] x86/pass-through: use simpler locking primitives in pt_irq_{create,destroy}_bind()
Date: Fri, 25 Sep 2026 18:14:27 +0200 [thread overview]
Message-ID: <arad42KgIIfphCWC@macbook.local> (raw)
In-Reply-To: <d9cedc6d-6884-4565-a62e-08bd8aefd236@suse.com>
On Tue, Sep 08, 2026 at 03:03:45PM +0200, Jan Beulich wrote:
> Both functions already assume IRQs to be enabled upon entry, by e.g. their
> acquiring of the domain's event channel lock. Hence like e.g.
> hvm_migrate_pirq() (also called from here) does, saving/restoring of
> EFLAGS.IF isn't necessary (because of the functions called, we can't
> really avoid the saving there).
To clarify this expectation (as code moves around and changes), I
would introduce an explicit ASSERT() that interrupts are enabled.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Preferably with the above:
Acked-by: Roger Pau Monné <roger@xenproject.org>
Thanks, Roger.
next prev parent reply other threads:[~2026-09-25 16:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 13:00 [PATCH 0/6] x86: pass-through / {,v}PCI locking Jan Beulich
2026-09-08 13:01 ` [PATCH 1/6] x86/pass-through: defer event unlock in pt_irq_create_bind() Jan Beulich
2026-09-22 13:37 ` Roger Pau Monné
2026-09-22 14:59 ` Jan Beulich
2026-09-08 13:01 ` [PATCH 2/6] x86/pass-through: no locking around pt_irq_{create,destroy}_bind() Jan Beulich
2026-09-23 10:37 ` Roger Pau Monné
2026-09-24 9:57 ` Jan Beulich
2026-09-25 14:53 ` Roger Pau Monné
2026-09-28 12:50 ` Jan Beulich
2026-09-29 9:31 ` Roger Pau Monné
2026-09-08 13:02 ` [PATCH 3/6] x86/vPCI: tighten locking assertions Jan Beulich
2026-09-24 9:02 ` Roger Pau Monné
2026-09-08 13:03 ` [PATCH 4/6] vPCI: drop bogus locking assertion Jan Beulich
2026-09-24 9:28 ` Roger Pau Monné
2026-09-08 13:03 ` [PATCH 5/6] x86/pass-through: use simpler locking primitives in pt_irq_{create,destroy}_bind() Jan Beulich
2026-09-25 16:14 ` Roger Pau Monné [this message]
2026-09-08 13:04 ` [PATCH 6/6] x86/HVM: drop vector parameter from .pi_update_irte() hook Jan Beulich
2026-09-25 16:15 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arad42KgIIfphCWC@macbook.local \
--to=roger@xenproject.org \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.