All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Mehltretter <kmehltretter@gmail.com>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: Doug Berger <opendmb@gmail.com>,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	 Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Justin Chen <justin.chen@broadcom.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: bcmgenet: allocate RX buffers as page fragments
Date: Fri, 25 Sep 2026 19:11:40 +0200	[thread overview]
Message-ID: <araqwSZWDYqbPZWa@gmail.com> (raw)
In-Reply-To: <20260924101922.2675127-1-nb@tipi-net.de>

On Thu, Sep 24, 2026 at 12:19:21PM +0100, Nicolai Buchwitz wrote:
> Fix this and allocate the buffers as page fragments, so the truesize is
> what a packet occupies. 4 KiB pages stay one buffer per page.
> 

Tested-by: Karl Mehltretter <kmehltretter@gmail.com>

I applied this unchanged to current net at 11536ee3d3e0, current net-next at
42a9fb3382fc, and after patches 129 and 130 from 6.18.54-rc1. I tested each
with a 64 KiB arm64 kernel in a custom QEMU Pi 400 model with GENET v5 DMA.

My LLM agent helped me running these tests.

Results with a 524,288-byte receive buffer (repeated over five rounds):

                             Unpatched net   Patched net/net-next
Charge per 512-byte UDP      65,792 bytes    2,624 bytes
Datagrams queued (of 1,000)  7               195
Socket drops                 993             805

Thanks,
Karl

  parent reply	other threads:[~2026-09-25 17:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 10:19 [PATCH net] net: bcmgenet: allocate RX buffers as page fragments Nicolai Buchwitz
2026-09-25 13:47 ` Simon Horman
2026-09-25 13:59   ` Nicolai Buchwitz
2026-09-25 16:57     ` Simon Horman
2026-09-25 17:11 ` Karl Mehltretter [this message]
2026-09-26  0:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=araqwSZWDYqbPZWa@gmail.com \
    --to=kmehltretter@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=justin.chen@broadcom.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.