From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: david@ixit.cz
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Petr Hodina <petr.hodina@protonmail.com>,
linux-input@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v7 2/4] dt-bindings: input: touchscreen: st,stmfts: Introduce STM FTS5
Date: Fri, 25 Sep 2026 12:19:21 -0700 [thread overview]
Message-ID: <arbIsdvRzPCqPXfs@google.com> (raw)
In-Reply-To: <20260907-stmfts5-v7-2-4a53381cd038@ixit.cz>
Hi David,
On Mon, Sep 07, 2026 at 12:50:20PM +0200, David Heidelberg via B4 Relay wrote:
> touchscreen@49 {
> compatible = "st,stmfts";
> reg = <0x49>;
> - interrupt-parent = <&gpa1>;
> - interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> - touchscreen-size-x = <1599>;
> - touchscreen-size-y = <2559>;
> + interrupts-extended = <&gpa1 1 IRQ_TYPE_LEVEL_LOW>;
> + touchscreen-size-x = <1600>;
> + touchscreen-size-y = <2560>;
Krzysztof questioned this change. You need to explain why this is being
changed (and potentially split it into a separate patch as it does not
seem to be related to STMFT5 introduction).
> touch-key-connected;
> avdd-supply = <&ldo30_reg>;
> vdd-supply = <&ldo31_reg>;
> ledvdd-supply = <&ldo33_reg>;
> };
> };
>
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-09-25 19:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 10:50 [PATCH v7 0/4] Input: support for STM FTS5 David Heidelberg via B4 Relay
2026-09-07 10:50 ` David Heidelberg
2026-09-07 10:50 ` [PATCH v7 1/4] Input: stmfts - wait for controller ready after reset David Heidelberg via B4 Relay
2026-09-07 10:50 ` David Heidelberg
2026-09-07 11:06 ` sashiko-bot
2026-09-25 19:27 ` Dmitry Torokhov
2026-09-25 20:20 ` David Heidelberg
2026-09-25 20:36 ` Dmitry Torokhov
2026-09-07 10:50 ` [PATCH v7 2/4] dt-bindings: input: touchscreen: st,stmfts: Introduce STM FTS5 David Heidelberg via B4 Relay
2026-09-07 10:50 ` David Heidelberg
2026-09-07 11:00 ` sashiko-bot
2026-09-25 19:19 ` Dmitry Torokhov [this message]
2026-09-25 19:48 ` David Heidelberg
2026-09-07 10:50 ` [PATCH v7 3/4] Input: stmfts - support FTS5 David Heidelberg via B4 Relay
2026-09-07 10:50 ` David Heidelberg
2026-09-07 11:04 ` sashiko-bot
2026-09-25 19:21 ` Dmitry Torokhov
2026-09-07 10:50 ` [PATCH v7 4/4] arm64: dts: qcom: sdm845-google: Add STM FTS touchscreen support David Heidelberg via B4 Relay
2026-09-07 10:50 ` David Heidelberg
2026-09-07 10:58 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arbIsdvRzPCqPXfs@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=petr.hodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.