From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy2-f43.google.com (mail-dy2-f43.google.com [74.125.229.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFAC0443C17 for ; Fri, 25 Sep 2026 19:21:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.229.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790364075; cv=none; b=ctTwWrIZjasdHla1RmVbcjgxH84H5SQig90B19ZH7/p9z1vD0t5YlpWP6AfZ/hMgF7Sfeg+sqDTKxxuGCAr3GWqTfGNTIgwbEBf+JZYN6klqvlZwJb2Yt5A9yZ1kXP2QA6uQnK1MotLlPjDfomk6okHtXQ0+0/Nz2q5vFvq70TY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790364075; c=relaxed/simple; bh=KAeKmkNkjuzZG9TiPoOsXDj84d0lGdVN5Hwuzhdo3zg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NAjYBZEXm/PoTq5FT3uc2G5jBTqL/sfHK8GHkWgb9cTmBXTP8hWnAvwo/TU/hmqz5NlhIOAlXP9CA5uj2O6seiU9TImJTVNZzomd/U+BexvAVPGIAbP/AtcCyidiZBYgvCnCS9/Aon19mvg1pbMLkrafb7r8h7r+OsPqFnbhBio= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=asnoedmm; arc=none smtp.client-ip=74.125.229.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="asnoedmm" Received: by mail-dy2-f43.google.com with SMTP id 5a478bee46e88-33bfb26865fso1037972eec.2 for ; Fri, 25 Sep 2026 12:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790364073; x=1790968873; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1AlSXbEjro2stcGQ4JnkFbJoY4FQMoz5yKwywTEmVVk=; b=asnoedmmhW/NUgBMm4aBxVE8jnMtXHZduRTjnB9dHZOs+nq3V1NZUKbuLsae4L4pNs 0lDYM/GFZFz7WCAEWX2h+4B0/VRo3iPsh6nAwt9jNhrj8YNaB7hj8IonGtdWigySKwSP 2Dsw9Wg4WOImILktjwM7YSrdpU5d448GgHLjB1wZ/XLMGFaW6w3pdz+PJizTZ68OGam1 wUmHY9vSsdkT/6DatSVcBALStHe5faJmI36urSzWK44YbLUONVANz+RHM4ip++IZ56Do GaqWZwcUsR2lLwAn1GEUazWbXYXKjHmdhrbtplL7plnddVWgJ1QFcsFAmiquxIUcLzhL OaNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790364073; x=1790968873; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1AlSXbEjro2stcGQ4JnkFbJoY4FQMoz5yKwywTEmVVk=; b=ikTh8qRnMjzMF6PHF78Cm5Oo+GHrCZ7la7S9LNagr50QYHjRw3ky5OlDpeYHnPx/Zt BTbjfFtavoYZxhUAx0PT3nobsBMBCFprRtxxaaaAEUPR7+vCx9YcD9SRpj9ZIVWqWEor Fs4yl2FWci3NZbz5AwTkuTQzLo+YjBC6nOQ0r9RrtyzM5K3iDHarfCKoAh37UZScIiqE 1Qz9mZbvnIUIqLctmKvrbTAQiLxnauAfI/Uexza0sfqa/rKoHNhh8fj7NBXqTP+5v9Sd a+K80OXdD4f21MrDgax3sUJVFWJeF3ZNm+Xq1OCcwLvWck5rckpLl/xi09+HVOFXUULc vZ9Q== X-Forwarded-Encrypted: i=1; AKwUvBx3KMG1zyAcDn1P27sSVQh6Z+NhU3Eu7bFbM1PhQKKL2awcFne8wZlHPXALf36CGTq28SjznuVgwsYd9Q==@vger.kernel.org X-Gm-Message-State: AFuF++n4QrccjILTKHVB4UsMK7J8otIkIQCKhqwLChsqsbTYEjU8HxYi ui+3vRso0p2YVvOTtD56BoJ0W5Ue15QjRH+6Nc3gODJPtCX/XsNnKvxK X-Gm-Gg: AYBFou2DMpPPCymVd5mJcbmQHbqKO6lAaGXrdiV+97mTJoyzLzlb8s5MtflKhzmzWLn SX/ks1jNkKNn4cq6FZ/9Rz4igNqba+gICzsSEytP7Ve468acx1V4Kav78FHeTubTBLQblKFKgma Z920LjB3NDKcOkD7bfAo2qpsMzVK8UhEjMxz6aLvRHBKkszr7C4UWIfvqtmW+XsIs2v10S1nDxv 2wY2LrFdhVqaFtia956t9AkSTxOQHBfCgzWJfewm1PhwL6qhReX09j6TEBrJ3xV3zRQpr3Iyhhd O6cWxqSnPnma49HA8FrTMTKdNS4I377nUfm944SNUfDcwYqNvQ+OdvqXGju+r3rHwH4Z0TtTzez rOaKTC10GGRGTo8QPNOYig9KUPSHf031fE4wDx+dCE6o0jNjYcPKFH0XWHuFcjWT0URC285CEg/ GkDgL4FkiyZmcP9TBob6SplCOnxrvJBdLHwMImTEXDZld29kRGJ/vl/xmpx7KIi7IpuZLxMUfh4 elZo/r5oQq1xqSLkhc+oM+6n5AbZVIciH6zONA= X-Received: by 2002:a05:7022:7e85:b0:143:3242:6301 with SMTP id a92af1059eb24-146ce29fde5mr1024848c88.4.1790364071957; Fri, 25 Sep 2026 12:21:11 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:375:19cf:5fee:be32]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-146bb6551d9sm1708481c88.9.2026.09.25.12.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Sep 2026 12:21:10 -0700 (PDT) Date: Fri, 25 Sep 2026 12:21:07 -0700 From: Dmitry Torokhov To: david@ixit.cz Cc: Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio , Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org Subject: Re: [PATCH v7 3/4] Input: stmfts - support FTS5 Message-ID: References: <20260907-stmfts5-v7-0-4a53381cd038@ixit.cz> <20260907-stmfts5-v7-3-4a53381cd038@ixit.cz> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260907-stmfts5-v7-3-4a53381cd038@ixit.cz> Hi David, On Mon, Sep 07, 2026 at 12:50:21PM +0200, David Heidelberg via B4 Relay wrote: > +static int stmfts5_setup_input(struct stmfts_data *sdata) > +{ > + struct device *dev = &sdata->client->dev; > + > + sdata->mode_switch_gpio = devm_gpiod_get_optional(dev, "mode-switch", > + GPIOD_OUT_HIGH); > + if (IS_ERR(sdata->mode_switch_gpio)) > + return dev_err_probe(dev, PTR_ERR(sdata->mode_switch_gpio), > + "Failed to get GPIO 'switch'\n"); > + > + /* Set resolution for accurate calibration */ > + if (!input_abs_get_res(sdata->input, ABS_MT_POSITION_X)) { > + input_abs_set_res(sdata->input, ABS_MT_POSITION_X, 10); > + input_abs_set_res(sdata->input, ABS_MT_POSITION_Y, 10); > + } > + > + input_set_abs_params(sdata->input, ABS_MT_DISTANCE, 0, 255, 0, 0); You need input_set_abs_params(sdata->input, ABS_MT_TOOL_TYPE, 0, MT_TOOL_PALM, 0, 0); here, otherwise input core will drop ABS_MT_TOOL_TYPE events. Thanks. -- Dmitry