From: Dan Carpenter <error27@gmail.com>
To: Slavin Liu <bolin.liu@seu.edu.cn>
Cc: shengjiu.wang@gmail.com, xiubo.lee@gmail.com,
lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, festevam@gmail.com, nicoleotsuka@gmail.com,
linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_asrc: check the second front-end DMA channel
Date: Sat, 26 Sep 2026 17:37:56 +0300 [thread overview]
Message-ID: <arfYxD95RJRcKCbZ@stanley.mountain> (raw)
In-Reply-To: <20260926141011.451552-1-bolin.liu@seu.edu.cn>
On Sat, Sep 26, 2026 at 10:10:11PM +0800, Slavin Liu wrote:
> Hi Dan,
>
> On Sat, Sep 26, 2026 at 04:19:38PM +0300, Dan Carpenter wrote:
> > The ->get_dma_channel() function pointer returns error pointers not
> > NULL.
> >
> > sound/soc/fsl/fsl_asrc_dma.c:254 fsl_asrc_dma_hw_params()
> > warn: 'tmp_chan' is an error pointer or valid
> >
> > sound/soc/fsl/fsl_easrc.c | (struct fsl_asrc)->get_dma_channel | fsl_easrc_get_dma_channel | 1
> > sound/soc/fsl/fsl_asrc.c | (struct fsl_asrc)->get_dma_channel | fsl_asrc_get_dma_channel | 1
>
> Is this a false positive?: both implementations return
> dma_request_slave_channel().
Ah, you're looking at old code. It changed from NULL to error pointers
last week. The dma_request_slave_channel() function was deleted entirely
since there are no more callers in the kernel.
https://lore.kernel.org/all/20260918113727.1898998-6-andriy.shevchenko@linux.intel.com/
regards,
dan carpenter
next prev parent reply other threads:[~2026-09-26 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 12:51 [PATCH] ASoC: fsl_asrc: check the second front-end DMA channel Slavin Liu
2026-09-24 22:30 ` Mark Brown
2026-09-26 13:19 ` Dan Carpenter
2026-09-26 14:10 ` Slavin Liu
2026-09-26 14:37 ` Dan Carpenter [this message]
2026-09-27 0:08 ` Slavin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arfYxD95RJRcKCbZ@stanley.mountain \
--to=error27@gmail.com \
--cc=bolin.liu@seu.edu.cn \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=xiubo.lee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.