From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from hall.aurel32.net (hall.aurel32.net [195.154.119.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B26893009CB; Sun, 27 Sep 2026 21:18:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.154.119.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790543905; cv=none; b=cfsAwfvSwKj+72L2PQcqZOZ0IuaBeYvjDM8T3t76slIO0h5uAmaz/rOYVgRvl7UQUKQH1HSxd/GdcPVjBN6ut6jh9mhJugHqrAwiRPZqpqty9c3AcJcANBh0cJx9hvANd3KK0b6YF0sJ+BE/WeYVGlH+yXby4emGUn5KSXJCbcQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790543905; c=relaxed/simple; bh=xCFj/xxiXd1WNuyxbAfLfrlA9x5UoRqcQp528m1GniM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dG+n6m1msE/gS7AUsHwUpUl9fQX9eORaCXtnCR6Pcd4IK4KvHS19lS/6/7cmHaN6J6TUAgpPvz4zw/574zTghD3+7WuntVscNRexeU8MPikZ4sQKk30gwknefnsU5vV+KX/XKXf+bAjPhEZggJ8L0m8F2hFZt+jEybOHzo1W+w4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net; spf=pass smtp.mailfrom=aurel32.net; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b=Si+XEBRs; arc=none smtp.client-ip=195.154.119.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aurel32.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aurel32.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aurel32.net header.i=@aurel32.net header.b="Si+XEBRs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=33MsHDwPKKkx+NSkez8Et2HM/X24ivhJAbyLs8SiZQw=; b=Si+XEBRscLmCml1/lRIrfwcH5M MI5OhSA8PoN9qtCZVS0OgnoqsdinGm8UdpAQNxfzwsjI4EfN9YT0h+y17f0At4B/LNVR9LKnEBSA6 LcQeQHdxqns41n5OIv3N6Trf3N746CDPoRex/acXy7we9vM5BT4z6g8+PZzlVsnI+TXNT1JpgOtM2 dA7pJbAweyePTZAp3mffCHHkpcItFPZo+Lc76jVbO0giudX8S8Oc/0KKeuphZ56sv9zyyFZOXLHTo 3g8x9N22+VhD2ICCCFy20VaJMi4mO0Kdm4w8SYMvHuOpdPR6bbkB+fu2qAWuKd8X+cSn4InqCbxr6 GviGGnfg==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xAwGC-0000000DQ9b-0cFC; Sun, 27 Sep 2026 23:18:12 +0200 Date: Sun, 27 Sep 2026 23:18:11 +0200 From: Aurelien Jarno To: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Inochi Amaoto Cc: Aurelien Jarno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" Subject: Re: [PATCH v3 1/5] riscv: dts: spacemit: k3: move USB3 phy to board level Message-ID: Mail-Followup-To: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Inochi Amaoto , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" References: <20260831044540.3304350-1-aurelien@aurel32.net> <20260831044540.3304350-2-aurelien@aurel32.net> <20260831045448.58B591F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260831045448.58B591F000E9@smtp.kernel.org> User-Agent: Mutt/2.4.1 (2026-07-04) Hi, On 2026-08-31 04:54, sashiko-bot@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issu= e(s) to consider: > - [Low] Removing 'phys' and 'phy-names' from the base k3.dtsi breaks DT s= chema validation (dtbs_check) for disabled nodes and improperly delegates f= ixed SoC routing to board files. > -- >=20 > commit e9dc7ad92d5f4a805cf362fdd51c6ae160da1934 > Author: Aurelien Jarno >=20 > riscv: dts: spacemit: k3: move USB3 phy to board level >=20 > This commit moves the USB3 phy definitions from the SoC dtsi to the board > level dts files for the SpacemiT K3 SoC. It aims to prevent PHY mode > configuration errors when the combo PHY lines are used for PCIe rather th= an > USB3. >=20 > [ ... ] > > diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts= /spacemit/k3.dtsi > > index c3f2dce0969c0..6f8d55eae6f6b 100644 > > --- a/arch/riscv/boot/dts/spacemit/k3.dtsi > > +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi > > @@ -452,9 +452,6 @@ usb3d: usb@81a00000 { > > <&syscon_apmu RESET_APMU_USB3_D_VCC>, > > <&syscon_apmu RESET_APMU_USB3_D_PHY>; > > reset-names =3D "ahb", "vcc", "phy"; > > - phys =3D <&usb3d_u2phy>, > > - <&combophy 4 PHY_TYPE_USB3>; > > - phy-names =3D "usb2-phy", "usb3-phy"; >=20 > [Severity: Low] > Does removing phys and phy-names from the base k3.dtsi break DT schema > validation (dtbs_check) for disabled nodes? No it doesn't. dtbs_check seems to ignore disabled nodes. > To satisfy the schema's minItems: 1 requirement while supporting board-le= vel > combo PHY configuration, should the dedicated internal SoC PHY (usb3d_u2p= hy) > have been retained in the base file? >=20 > The dtbs_check validation will fail for any board DT that includes k3.dtsi > but does not override the usb3d node to provide the phys and phy-names > properties (e.g., k3-com260-ifx.dts and k3-deepcomputing-fml13v05.dts). I have just tried, in practice it doesn't. I'll send a new version=20 mentioning that. > This happens because the schema spacemit,k1-dwc3.yaml unconditionally > requires these properties, and dt-schema evaluates all nodes, even disabl= ed > ones. >=20 > > phy_type =3D "utmi"; > > snps,dis_enblslpm_quirk; > > snps,dis_u2_susphy_quirk; >=20 > --=20 > Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260831044540.33= 04350-1-aurelien@aurel32.net?part=3D1 >=20 --=20 Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://aurel32.net From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DE6BC98338 for ; Sun, 27 Sep 2026 21:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eWvVvoxAJpUIr3oX89D0wiNd9c0DqNdq3XMcfmdqerE=; b=F8yJY6TIzMOgky r6YWaGZAwOOAxBsXaxBFcIdvFIxX2pBtYlhSYQkUzqPWa3XiYUnHWDgdVPCDx57rFz5B3lRq1fu+C P/h7p7ZTPR1p68R6Rxps8yyy1UWEsJzV539sdctGfzDYmq4Nu7Hrjvc8OaoeSRuqMpjCZP5NgWd/5 SzI2SVhG13seW/IsooSPeY1RzUDOxfz3aFIYi2Zd7IVNDK+awJFyULGtMgd14YjO/Z0oRIt8vv+uF xveY4w5AMF8c9lZs4Ktdr2va7Bj0PeBLyu8G7glojcDb0At5gGYdyRbLfVBjnwwF5bdfyGX4/J9cB JkvBI1sIaoEPsdLp3bSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAwGQ-0000000GsnQ-3CKF; Sun, 27 Sep 2026 21:18:26 +0000 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xAwGO-0000000Gsmy-0rSW for linux-riscv@lists.infradead.org; Sun, 27 Sep 2026 21:18:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=33MsHDwPKKkx+NSkez8Et2HM/X24ivhJAbyLs8SiZQw=; b=Si+XEBRscLmCml1/lRIrfwcH5M MI5OhSA8PoN9qtCZVS0OgnoqsdinGm8UdpAQNxfzwsjI4EfN9YT0h+y17f0At4B/LNVR9LKnEBSA6 LcQeQHdxqns41n5OIv3N6Trf3N746CDPoRex/acXy7we9vM5BT4z6g8+PZzlVsnI+TXNT1JpgOtM2 dA7pJbAweyePTZAp3mffCHHkpcItFPZo+Lc76jVbO0giudX8S8Oc/0KKeuphZ56sv9zyyFZOXLHTo 3g8x9N22+VhD2ICCCFy20VaJMi4mO0Kdm4w8SYMvHuOpdPR6bbkB+fu2qAWuKd8X+cSn4InqCbxr6 GviGGnfg==; Received: from authenticated user by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xAwGC-0000000DQ9b-0cFC; Sun, 27 Sep 2026 23:18:12 +0200 Date: Sun, 27 Sep 2026 23:18:11 +0200 From: Aurelien Jarno To: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Inochi Amaoto Cc: Aurelien Jarno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" Subject: Re: [PATCH v3 1/5] riscv: dts: spacemit: k3: move USB3 phy to board level Message-ID: Mail-Followup-To: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yixun Lan , Inochi Amaoto , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:RISC-V SPACEMIT SoC Support" , "open list:RISC-V SPACEMIT SoC Support" References: <20260831044540.3304350-1-aurelien@aurel32.net> <20260831044540.3304350-2-aurelien@aurel32.net> <20260831045448.58B591F000E9@smtp.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260831045448.58B591F000E9@smtp.kernel.org> User-Agent: Mutt/2.4.1 (2026-07-04) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260927_141824_249196_43790A95 X-CRM114-Status: GOOD ( 14.97 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGksCgpPbiAyMDI2LTA4LTMxIDA0OjU0LCBzYXNoaWtvLWJvdEBrZXJuZWwub3JnIHdyb3RlOgo+ IFRoYW5rIHlvdSBmb3IgeW91ciBjb250cmlidXRpb24hIFNhc2hpa28gQUkgcmV2aWV3IGZvdW5k IDEgcG90ZW50aWFsIGlzc3VlKHMpIHRvIGNvbnNpZGVyOgo+IC0gW0xvd10gUmVtb3ZpbmcgJ3Bo eXMnIGFuZCAncGh5LW5hbWVzJyBmcm9tIHRoZSBiYXNlIGszLmR0c2kgYnJlYWtzIERUIHNjaGVt YSB2YWxpZGF0aW9uIChkdGJzX2NoZWNrKSBmb3IgZGlzYWJsZWQgbm9kZXMgYW5kIGltcHJvcGVy bHkgZGVsZWdhdGVzIGZpeGVkIFNvQyByb3V0aW5nIHRvIGJvYXJkIGZpbGVzLgo+IC0tCj4gCj4g Y29tbWl0IGU5ZGM3YWQ5MmQ1ZjRhODA1Y2YzNjJmZGQ1MWM2YWUxNjBkYTE5MzQKPiBBdXRob3I6 IEF1cmVsaWVuIEphcm5vIDxhdXJlbGllbkBhdXJlbDMyLm5ldD4KPiAKPiByaXNjdjogZHRzOiBz cGFjZW1pdDogazM6IG1vdmUgVVNCMyBwaHkgdG8gYm9hcmQgbGV2ZWwKPiAKPiBUaGlzIGNvbW1p dCBtb3ZlcyB0aGUgVVNCMyBwaHkgZGVmaW5pdGlvbnMgZnJvbSB0aGUgU29DIGR0c2kgdG8gdGhl IGJvYXJkCj4gbGV2ZWwgZHRzIGZpbGVzIGZvciB0aGUgU3BhY2VtaVQgSzMgU29DLiBJdCBhaW1z IHRvIHByZXZlbnQgUEhZIG1vZGUKPiBjb25maWd1cmF0aW9uIGVycm9ycyB3aGVuIHRoZSBjb21i byBQSFkgbGluZXMgYXJlIHVzZWQgZm9yIFBDSWUgcmF0aGVyIHRoYW4KPiBVU0IzLgo+IAo+IFsg Li4uIF0KPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3NwYWNlbWl0L2szLmR0 c2kgYi9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3NwYWNlbWl0L2szLmR0c2kKPiA+IGluZGV4IGMzZjJk Y2UwOTY5YzAuLjZmOGQ1NWVhZTZmNmIgMTAwNjQ0Cj4gPiAtLS0gYS9hcmNoL3Jpc2N2L2Jvb3Qv ZHRzL3NwYWNlbWl0L2szLmR0c2kKPiA+ICsrKyBiL2FyY2gvcmlzY3YvYm9vdC9kdHMvc3BhY2Vt aXQvazMuZHRzaQo+ID4gQEAgLTQ1Miw5ICs0NTIsNiBAQCB1c2IzZDogdXNiQDgxYTAwMDAwIHsK PiA+ICAJCQkJIDwmc3lzY29uX2FwbXUgUkVTRVRfQVBNVV9VU0IzX0RfVkNDPiwKPiA+ICAJCQkJ IDwmc3lzY29uX2FwbXUgUkVTRVRfQVBNVV9VU0IzX0RfUEhZPjsKPiA+ICAJCQlyZXNldC1uYW1l cyA9ICJhaGIiLCAidmNjIiwgInBoeSI7Cj4gPiAtCQkJcGh5cyA9IDwmdXNiM2RfdTJwaHk+LAo+ ID4gLQkJCSAgICAgICA8JmNvbWJvcGh5IDQgUEhZX1RZUEVfVVNCMz47Cj4gPiAtCQkJcGh5LW5h bWVzID0gInVzYjItcGh5IiwgInVzYjMtcGh5IjsKPiAKPiBbU2V2ZXJpdHk6IExvd10KPiBEb2Vz IHJlbW92aW5nIHBoeXMgYW5kIHBoeS1uYW1lcyBmcm9tIHRoZSBiYXNlIGszLmR0c2kgYnJlYWsg RFQgc2NoZW1hCj4gdmFsaWRhdGlvbiAoZHRic19jaGVjaykgZm9yIGRpc2FibGVkIG5vZGVzPwoK Tm8gaXQgZG9lc24ndC4gZHRic19jaGVjayBzZWVtcyB0byBpZ25vcmUgZGlzYWJsZWQgbm9kZXMu Cgo+IFRvIHNhdGlzZnkgdGhlIHNjaGVtYSdzIG1pbkl0ZW1zOiAxIHJlcXVpcmVtZW50IHdoaWxl IHN1cHBvcnRpbmcgYm9hcmQtbGV2ZWwKPiBjb21ibyBQSFkgY29uZmlndXJhdGlvbiwgc2hvdWxk IHRoZSBkZWRpY2F0ZWQgaW50ZXJuYWwgU29DIFBIWSAodXNiM2RfdTJwaHkpCj4gaGF2ZSBiZWVu IHJldGFpbmVkIGluIHRoZSBiYXNlIGZpbGU/Cj4gCj4gVGhlIGR0YnNfY2hlY2sgdmFsaWRhdGlv biB3aWxsIGZhaWwgZm9yIGFueSBib2FyZCBEVCB0aGF0IGluY2x1ZGVzIGszLmR0c2kKPiBidXQg ZG9lcyBub3Qgb3ZlcnJpZGUgdGhlIHVzYjNkIG5vZGUgdG8gcHJvdmlkZSB0aGUgcGh5cyBhbmQg cGh5LW5hbWVzCj4gcHJvcGVydGllcyAoZS5nLiwgazMtY29tMjYwLWlmeC5kdHMgYW5kIGszLWRl ZXBjb21wdXRpbmctZm1sMTN2MDUuZHRzKS4KCkkgaGF2ZSBqdXN0IHRyaWVkLCBpbiBwcmFjdGlj ZSBpdCBkb2Vzbid0LiBJJ2xsIHNlbmQgYSBuZXcgdmVyc2lvbiAKbWVudGlvbmluZyB0aGF0LgoK PiBUaGlzIGhhcHBlbnMgYmVjYXVzZSB0aGUgc2NoZW1hIHNwYWNlbWl0LGsxLWR3YzMueWFtbCB1 bmNvbmRpdGlvbmFsbHkKPiByZXF1aXJlcyB0aGVzZSBwcm9wZXJ0aWVzLCBhbmQgZHQtc2NoZW1h IGV2YWx1YXRlcyBhbGwgbm9kZXMsIGV2ZW4gZGlzYWJsZWQKPiBvbmVzLgo+IAo+ID4gIAkJCXBo eV90eXBlID0gInV0bWkiOwo+ID4gIAkJCXNucHMsZGlzX2VuYmxzbHBtX3F1aXJrOwo+ID4gIAkJ CXNucHMsZGlzX3UyX3N1c3BoeV9xdWlyazsKPiAKPiAtLSAKPiBTYXNoaWtvIEFJIHJldmlldyDC tyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA4MzEwNDQ1NDAuMzMwNDM1MC0x LWF1cmVsaWVuQGF1cmVsMzIubmV0P3BhcnQ9MQo+IAoKLS0gCkF1cmVsaWVuIEphcm5vICAgICAg ICAgICAgICAgICAgICAgICAgICBHUEc6IDQwOTZSLzFEREQ4QzlCCmF1cmVsaWVuQGF1cmVsMzIu bmV0ICAgICAgICAgICAgICAgICAgICAgaHR0cDovL2F1cmVsMzIubmV0CgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxp c3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==