From: Christoph Hellwig <hch@infradead.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
hch@infradead.org, sgoutham@marvell.com, rkannoth@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, bbhushan2@marvell.com,
lcherian@marvell.com
Subject: Re: [PATCH net-next] octeontx2: remove unneeded symbol exports
Date: Sun, 27 Sep 2026 22:16:01 -0700 [thread overview]
Message-ID: <arn4Efet4feI-WFl@infradead.org> (raw)
In-Reply-To: <20260925201042.1174488-1-kuba@kernel.org>
On Fri, Sep 25, 2026 at 01:10:42PM -0700, Jakub Kicinski wrote:
> octeontx2 has a bunch of symbols not used outside the module which
> defines them. Worse, still the macro which defines otx2_mbox_up_handler_*
> adds exports for all the functions. Remove all the explicit exports
> and the auto-export from that macro.
>
> otx2_mbox_up_handler_cgx_link_event was exported by the macro and
> is genuienly called from the VF driver, so add an export.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-09-28 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 20:10 [PATCH net-next] octeontx2: remove unneeded symbol exports Jakub Kicinski
2026-09-28 5:16 ` Christoph Hellwig [this message]
2026-09-28 11:24 ` Sunil Kovvuri Goutham
2026-09-29 6:54 ` [EXTERNAL] " Geethasowjanya Akula
2026-09-30 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arn4Efet4feI-WFl@infradead.org \
--to=hch@infradead.org \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.