From: Christoph Hellwig <hch@infradead.org>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Hao Ge <hao.ge@linux.dev>, David Howells <dhowells@redhat.com>,
Paulo Alcantara <pc@manguebit.org>, Harry Yoo <harry@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Hao Li <hao.li@linux.dev>, Christoph Lameter <cl@gentwo.org>,
David Rientjes <rientjes@google.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
"Christian Brauner (Amutable)" <brauner@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Christoph Hellwig <hch@infradead.org>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Erhard Furtner <erhard_f@mailbox.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] netfs: Fix missing alloc tagging of direct mempool allocations
Date: Sun, 27 Sep 2026 22:28:52 -0700 [thread overview]
Message-ID: <arn7FHZpYhNDvjIS@infradead.org> (raw)
In-Reply-To: <0d798541-6486-44ff-ae57-f631d1465688@kernel.org>
On Thu, Sep 24, 2026 at 11:36:19AM +0200, Vlastimil Babka (SUSE) wrote:
> > Closes: https://lore.kernel.org/all/0b004319-9ef7-437c-a4dd-174d6a9a83db@mailbox.org/
> > Tested-by: Erhard Furtner <erhard_f@mailbox.org>
> > Suggested-by: Suren Baghdasaryan <surenb@google.com>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Hao Ge <hao.ge@linux.dev>
>
> Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org>
>
> Seems ok enough as a hotfix. The naming perhaps isn't ideal, we have
> mempool_alloc_preallocated() already for the opposite case. Maybe
> mempool_alloc_no_preallocated() to complement it? Rather long though.
None of this is ok. Directly alling into mempool->alloc, using a
wrapper and not is stupid and broken. Just switch the code to use
mempool_alloc undconditionally or to use a manually
kmalloc/kmem_cache_allow if the subsystem has a really good reason
to not use a mempool for non-writeback requests, but it'd better be
a really good and well-documented reason.
next prev parent reply other threads:[~2026-09-28 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 6:37 [PATCH v2] netfs: Fix missing alloc tagging of direct mempool allocations Hao Ge
2026-09-24 9:36 ` Vlastimil Babka (SUSE)
2026-09-28 5:28 ` Christoph Hellwig [this message]
2026-09-25 15:30 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arn7FHZpYhNDvjIS@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=cl@gentwo.org \
--cc=dhowells@redhat.com \
--cc=erhard_f@mailbox.org \
--cc=hao.ge@linux.dev \
--cc=hao.li@linux.dev \
--cc=harry@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.