From: Hangbin Liu <hangbin.liu@linux.dev>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Donald Hunter <donald.hunter@gmail.com>,
Danielle Ratson <danieller@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <o.rempel@pengutronix.de>
Subject: Re: [PATCH net-next v2 9/9] netlink: specs: fix incorrect name-prefixes
Date: Mon, 28 Sep 2026 10:00:14 +0800 [thread overview]
Message-ID: <arnJFLyI-idCF_OB@fedora> (raw)
In-Reply-To: <20260925213918.204767-10-ast@fiberby.net>
On Fri, Sep 25, 2026 at 09:39:12PM +0000, Asbjørn Sloth Tønnesen wrote:
> Fix two invalid name-prefixes in the specs:
>
> - It's PHY_UPSTREAM_MAC, not PHY_UPSTREAMMAC.
> - It's PHY_UPSTREAM_PHY, not PHY_UPSTREAMPHY.
> - It's OVPN_MODE_P2P, not OVPN_MODEP2P.
> - It's OVPN_MODE_MP, not OVPN_MODEMP.
>
> CC: Andrew Lunn <andrew@lunn.ch>
> CC: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
> ---
> Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.
>
> Documentation/netlink/specs/ethtool.yaml | 2 +-
> Documentation/netlink/specs/rt-link.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 6868eb473478..a66594ad9e73 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -99,7 +99,7 @@ definitions:
> enum-name: phy-upstream
> header: linux/ethtool.h
> type: enum
> - name-prefix: phy-upstream
> + name-prefix: phy-upstream-
> entries: [mac, phy]
> -
> name: tcp-data-split
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index e3a4b4e7e5ef..81b58633911d 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -842,7 +842,7 @@ definitions:
> -
> name: ovpn-mode
> enum-name: ovpn-mode
> - name-prefix: ovpn-mode
> + name-prefix: ovpn-mode-
> type: enum
> entries:
> - p2p
> --
> 2.55.0
>
Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
next prev parent reply other threads:[~2026-09-28 2:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 21:39 [PATCH net-next v2 0/9] netlink: specs: enum alignment fixes Asbjørn Sloth Tønnesen
2026-09-25 21:39 ` [PATCH net-next v2 1/9] netlink: specs: rt-link: re-align IPv4 devconf Asbjørn Sloth Tønnesen
2026-09-28 1:19 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 2/9] netlink: specs: rt-link: re-align ifla-inet6-stats Asbjørn Sloth Tønnesen
2026-09-28 1:28 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 3/9] netlink: specs: rt-link: fix ifinfo-flags names Asbjørn Sloth Tønnesen
2026-09-28 1:29 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 4/9] netlink: specs: devlink: fix resource-scope type Asbjørn Sloth Tønnesen
2026-09-28 2:01 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 5/9] netlink: specs: ethtool: re-align c33-pse-ext-state Asbjørn Sloth Tønnesen
2026-09-28 1:39 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 6/9] netlink: specs: ethtool: re-align module-fw-flash-status Asbjørn Sloth Tønnesen
2026-09-28 1:40 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 7/9] netlink: specs: nl80211: fix naming of enum members Asbjørn Sloth Tønnesen
2026-09-28 1:47 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 8/9] netlink: specs: tc: fix typo in cls-flags Asbjørn Sloth Tønnesen
2026-09-28 1:53 ` Hangbin Liu
2026-09-25 21:39 ` [PATCH net-next v2 9/9] netlink: specs: fix incorrect name-prefixes Asbjørn Sloth Tønnesen
2026-09-28 2:00 ` Hangbin Liu [this message]
2026-09-29 11:30 ` [PATCH net-next v2 0/9] netlink: specs: enum alignment fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arnJFLyI-idCF_OB@fedora \
--to=hangbin.liu@linux.dev \
--cc=andrew@lunn.ch \
--cc=ast@fiberby.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.