Re: [PATCH v2 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts

[Bjorn Andersson <andersson@kernel.org>]

On Thu, Sep 24, 2026 at 02:00:11PM +0300, Abel Vesa wrote:
> On 26-09-23 14:59:19, Konrad Dybcio wrote:
> > On 9/15/26 2:03 PM, Abel Vesa wrote:
> > > It turns out there is a UFS variant of the Eliza CQS SoM as well. So lets
> > > differentiate between them with -emmc and -ufs suffixes for DTBs and
> > > compatible strings.
> > > 
> > > Adding -emmc suffix for to the current Eliza CQS SoM and EVK devicetree
> > > files will not affect any current users as these boards have not reached
> > > public use yet.
> > > 
> > > Also, move the sound card support from the eliza-cqs-evk to the generic
> > > eliza-evk, which will allow it to be reused not only by the UFS variant,
> > > but also by the Eliza CQM EVK later on.
> > > 
> > > Changes in v2:
> > > - Actually replace (and remove) the eliza-cqs-evk.dtsi when the
> > >   eliza-cqs-evk-emmc.dtsi is added.
> > > - Collect Krzysztof's R-b tag.
> > > - Link to v1: https://patch.msgid.link/20260914-dts-qcom-eliza-add-ufs-variant-v1-0-78b3249eae61@oss.qualcomm.com
> > > 
> > > Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> > > ---
> > > Abel Vesa (5):
> > >       dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs
> > >       arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic
> > >       arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
> > >       arm64: dts: qcom: eliza: Add CQS SoM UFS variant
> > >       arm64: dts: qcom: eliza: Add CQS EVK UFS variant
> > 
> > I was hoping there would be a bit less duplication here..
> > 
> 
> Do you this so that one includes the other and then override ?

It's conceivable that the UFS-variant is a reworked version of the
eMMC-version, in which case that would make sense. It's also
conceivable that they are of equal standing in which case a dtsi with
all the shared pieces are suitable.

It's hard to say from the information provided...

Regards,
Bjorn