From: Zorro Lang <zlang@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: moritz.tanner@linbit.com, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/805: fix for external RT devices
Date: Mon, 28 Sep 2026 17:50:38 +0800 [thread overview]
Message-ID: <aro32oI1akyaTv8i@zlang-mailbox> (raw)
In-Reply-To: <20260924062118.2684441-1-hch@lst.de>
On Thu, Sep 24, 2026 at 08:21:18AM +0200, Christoph Hellwig wrote:
> use _mkfs_dev on the dm device instead of _scratch_mkfs_sized, otherwise
> the file system could be created with an external RT device, and will
> then fail to mount without it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
This change is good to me,
Reviewed-by: Zorro Lang <zlang@kernel.org>
> tests/generic/805 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/generic/805 b/tests/generic/805
> index ae498f5c6698..401829c4c6fc 100755
> --- a/tests/generic/805
> +++ b/tests/generic/805
> @@ -31,7 +31,7 @@ _cleanup()
> rm -f $tmp.*
> }
>
> -_require_scratch
> +_require_scratch_nocheck
> _require_dm_target linear
> _require_freeze
>
> @@ -39,13 +39,13 @@ echo "Silence is golden"
>
> size=$((256 * 1024 * 1024))
> size_in_sector=$((size / 512))
> -_scratch_mkfs_sized $size >> $seqres.full 2>&1
>
> node=$seq-test
> lvdev=/dev/mapper/$node
> table="0 $size_in_sector linear $SCRATCH_DEV 0"
> _dmsetup_create $node --table "$table" || \
> _fail "failed to create dm device"
> +_mkfs_dev $lvdev >> $seqres.full 2>&1
>
> _mount $lvdev $SCRATCH_MNT || _fail "failed to mount dm device"
>
> --
> 2.53.0
>
prev parent reply other threads:[~2026-09-28 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 6:21 [PATCH] generic/805: fix for external RT devices Christoph Hellwig
2026-09-24 13:56 ` Zorro Lang
2026-09-25 5:03 ` Christoph Hellwig
2026-09-28 9:50 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aro32oI1akyaTv8i@zlang-mailbox \
--to=zlang@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=moritz.tanner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.