From: Patrick Steinhardt <ps@pks.im>
To: Souma <git@5ouma.me>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v3 1/2] replay: allow callers to sign commits
Date: Mon, 28 Sep 2026 09:40:54 +0200 [thread overview]
Message-ID: <aroaBm1G2OjO2TiB@pks.im> (raw)
In-Reply-To: <20260912160045.36064-2-git@5ouma.me>
On Sun, Sep 13, 2026 at 01:00:44AM +0900, Souma wrote:
> Add a signing-key option to replay_revisions_options and pass it to
> commit_tree_extended() when creating replayed commits.
This is mostly sufficient. One bit of information that could be useful
to the reviewer is that the infra is not used anywhere yet. But that
does not warrant a reroll, as the patch looks good to me otherwise.
Patrick
next prev parent reply other threads:[~2026-09-28 7:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 14:50 [PATCH 0/3] history: sign rewritten commits Souma
2026-07-03 14:50 ` [PATCH 1/3] builtin/history: " Souma
2026-07-16 10:18 ` Patrick Steinhardt
2026-07-03 14:50 ` [PATCH 2/3] doc: document history signing options Souma
2026-07-16 10:18 ` Patrick Steinhardt
2026-07-03 14:50 ` [PATCH 3/3] t345x: cover signed history rewrites Souma
2026-07-17 14:51 ` [PATCH v2 0/2] history: support signing rewritten commits Souma
2026-07-17 14:51 ` [PATCH v2 1/2] replay: allow callers to sign commits Souma
2026-09-11 7:57 ` Patrick Steinhardt
2026-07-17 14:51 ` [PATCH v2 2/2] builtin/history: sign rewritten commits Souma
2026-09-11 7:57 ` Patrick Steinhardt
2026-09-12 16:00 ` [PATCH v3 0/2] history: support signing " Souma
2026-09-12 16:00 ` [PATCH v3 1/2] replay: allow callers to sign commits Souma
2026-09-28 7:40 ` Patrick Steinhardt [this message]
2026-09-12 16:00 ` [PATCH v3 2/2] history: sign rewritten commits Souma
2026-09-28 7:32 ` Patrick Steinhardt
2026-09-28 15:00 ` Junio C Hamano
2026-09-28 18:52 ` Junio C Hamano
2026-09-28 23:39 ` Souma
2026-10-02 13:27 ` [PATCH v4 0/2] " Souma
2026-10-02 22:47 ` Junio C Hamano
2026-10-03 13:38 ` Souma
2026-10-02 13:27 ` [PATCH v4 1/2] replay: allow callers to sign commits Souma
2026-10-02 13:27 ` [PATCH v4 2/2] history: sign rewritten commits Souma
2026-10-03 13:40 ` [PATCH v5 0/2] " Souma
2026-10-04 14:17 ` Junio C Hamano
2026-10-05 6:59 ` Souma
2026-10-06 15:58 ` Junio C Hamano
2026-10-03 13:40 ` [PATCH v5 1/2] replay: allow callers to sign commits Souma
2026-10-03 13:40 ` [PATCH v5 2/2] history: sign rewritten commits Souma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aroaBm1G2OjO2TiB@pks.im \
--to=ps@pks.im \
--cc=git@5ouma.me \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.