All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: John Ernberg <j@j-ernberg.se>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: glx depend on mesa3d{, -headers}
Date: Mon, 28 Sep 2026 10:50:26 +0200	[thread overview]
Message-ID: <aropi3gsdof7NK3g@windsurf> (raw)
In-Reply-To: <20260927204842.1113860-2-j@j-ernberg.se>

Hello John,

On Sun, Sep 27, 2026 at 10:48:41PM +0200, John Ernberg wrote:

> diff --git a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> index d1596a8a3f..7bf9b65f58 100644
> --- a/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> +++ b/package/x11r7/xserver_xorg-server/xserver_xorg-server.mk
> @@ -99,7 +99,10 @@ endif
>  
>  ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
>  XSERVER_XORG_SERVER_CONF_OPTS += --enable-dri --enable-glx
> -XSERVER_XORG_SERVER_DEPENDENCIES += libgl
> +XSERVER_XORG_SERVER_DEPENDENCIES += \
> +	libgl \
> +	$(if $(BR2_PACKAGE_MESA3D),mesa3d) \
> +	$(if $(BR2_PACKAGE_MESA3D_HEADERS),mesa3d-headers)

Thanks a lot for the patch. However, this cannot be correct as mesa3d
is not the only OpenGL provider. BR2_PACKAGE_HAS_LIBGL only tells you
"some OpenGL provider is available" and that "libgl" depends on this
OpenGL provider. But there are plenty of OpenGL providers which are
not mesa3d.

What is the failure that you are seeing, with which configuration?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-09-28  8:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27 20:48 [Buildroot] [PATCH 0/2] xorg mesa3d dependency fixes John Ernberg
2026-09-27 20:48 ` [Buildroot] [PATCH 1/2] package/x11r7/xserver_xorg-server: glx depend on mesa3d{, -headers} John Ernberg
2026-09-28  8:50   ` Thomas Petazzoni via buildroot [this message]
2026-09-28 21:01     ` John Ernberg
2026-09-27 20:48 ` [Buildroot] [PATCH 2/2] package/x11r7/xwayland: " John Ernberg
2026-09-28  8:51   ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aropi3gsdof7NK3g@windsurf \
    --to=buildroot@buildroot.org \
    --cc=j@j-ernberg.se \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.