From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B34A6CA5FA5 for ; Mon, 28 Sep 2026 14:33:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xBCPk-0003ND-I8; Mon, 28 Sep 2026 10:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBCPj-0003JZ-3K for qemu-devel@nongnu.org; Mon, 28 Sep 2026 10:33:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBCPh-0006MT-LJ for qemu-devel@nongnu.org; Mon, 28 Sep 2026 10:33:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790605984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7hNtoq+QCKP0BVAqbnz2FFTxGNlgsalY3IJzrMUYvqo=; b=IJRID6U/vugAS1AFATKfX9E6NsuusND97+ZK4ZmV27Pg0QGPebS8pxd+CkyaP0V1lVl5hG jfHSrywKe7QIrwSaJzg+6Atgdu8L/NHyo46J51zcSNan2cG5bD4LlBBLVk8p5Yz5z7pmJf pP/oGMggQktZjwLFQXNRh59+RacnjlE= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-VaYa17H6MRij5NsRHMSMJQ-1; Mon, 28 Sep 2026 10:32:59 -0400 X-MC-Unique: VaYa17H6MRij5NsRHMSMJQ-1 X-Mimecast-MFC-AGG-ID: VaYa17H6MRij5NsRHMSMJQ_1790605978 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7ABA9180A20F; Mon, 28 Sep 2026 14:32:57 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.36]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 11F1C30000E6; Mon, 28 Sep 2026 14:32:51 +0000 (UTC) Date: Mon, 28 Sep 2026 09:32:49 -0500 From: Eric Blake To: Markus Armbruster Cc: John Snow , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Fabiano Rosas , Hanna Reitz , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Paolo Bonzini , Zhao Liu , Jason Wang , qemu-block@nongnu.org, Igor Mammedov , Ani Sinha , "Michael S. Tsirkin" , Peter Xu , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Subject: Re: [PATCH v2 03/10] qapi: convert/split intros for block commands Message-ID: References: <20260921205712.1862167-1-jsnow@redhat.com> <20260921205712.1862167-4-jsnow@redhat.com> <877bkcwcl5.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877bkcwcl5.fsf@pond.sub.org> User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.238, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Sep 23, 2026 at 11:17:58AM +0200, Markus Armbruster wrote: > John Snow writes: > > > Signed-off-by: John Snow > > Consider mentioning how this affects rendered documentation: > > 1. blockdev-open-tray and blockdev-close-tray: first paragraph splits > > 2. block_set_io_throttle, nbd-server-add: Arguments: move up. I'm liking this series, but also the suggestions of documenting the known impacts. At this point, I'm trusting Markus' review rather than diving in deep myself, but you're welcome to add: Acked-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org