From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C74DEC9833E for ; Mon, 28 Sep 2026 10:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nm9CceTqCoyVP9tW6XQZTjPs1Sfu5dmPnaUj/HiaYr8=; b=cC+uJWXhd8WjZ9 C7N9MIkiwdzcWf972o7j954EgwKLakMfLT7/ERR+3DfCihZWMnQ66nqbUoQ0QY/Q1buD5dfUJXgHA 4oJI3cXrZunAT9EMZUyFmEhkRZPgJugxV4L8ga7D/GNgtr3FLpfnHarPAPfZgCdO9Mgh6CdaV8PAD 4GwWP+ppcJ3/IklNT3pVOTMVq5BHs//aBat4tGsIioA6OsQCMVignLYgoqq8SEYw1yayIDvuDNpwP 5EwKK4HLD1sjv7w/u7cdz5Fk2wd25LBcJES6a52lepQQEJeScKqU0deJWGM6V9YizSczN0b5kOzS7 xtND/ZzcBzDtGZmDVLoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xB92n-00000000PBJ-1EZC; Mon, 28 Sep 2026 10:57:13 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xB92k-00000000PAj-29g0 for linux-phy@lists.infradead.org; Mon, 28 Sep 2026 10:57:11 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68S9MjMT1213514 for ; Mon, 28 Sep 2026 10:57:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=S4yLLM7uCYQket8rd9Pq6dEX 97HjH+y8AYJVBdz3Q0E=; b=jvnTlAw2/E+rAGs2X7Wvf5URybq+Oylk43sy41mz wrWJMQXat9HZPX6PbNjPv1nuHWWPzgdBijazlIbRtYOpBMWZWV8UDNm1iGKME9nk gSAgOULoCVQh7Mmzcwycyu3ceN7akynxUtzIA7RpqnvWLOq/sdW16xG0XqZPEIBU +1FH7Sb0SJFX4SYt0nEJ7AM/tFKv6By71Y6JeWO06Ah7Sib5rrfFezTgYwhcn0db p5IFQOF9fxBiYEPoG3T+Gzy7M53raHJzPXAflYqbhH39QdeFZCiW/w4s7tNrjMFp uO9aH07nUKiBd3s1SC+iPmKp6i8kyEjznziTOajnxmqK2A== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gyjkxh307-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 28 Sep 2026 10:57:08 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38dbf293831so4504312a91.3 for ; Mon, 28 Sep 2026 03:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790593027; x=1791197827; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=S4yLLM7uCYQket8rd9Pq6dEX97HjH+y8AYJVBdz3Q0E=; b=Dg4P7z0cZ3f/OwhcOvw6SzkYXWn8rjc5g1wfZTWl0NFKxiPWEawhH2IFxf7FR1RbY2 zQCWJ3KIlhDvm/SmHVQifPkcDHy0AFgnIB2jB+AwwVD+lxLLWxzB8Z+ZsGD5jPU3wGzU cApe6SHuWkr0tt2zYBDR3H+YBZsPzkAX9Re5VQWkRKgj5TWuUNDIdGuztcXfkqanwSJN YnXkMZMPUHvnbp+J1kcsKCC0aBR6zymn+1HtKdnbNawBMD51jj338j79HQZTOGMgu7ZX EYnM8AIyC6aAUYYitEKNHmsSiTQbPkj3660zUJYObUsLF2wn+etkUN9aLjyKc3YKEpBQ sFng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790593027; x=1791197827; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S4yLLM7uCYQket8rd9Pq6dEX97HjH+y8AYJVBdz3Q0E=; b=kL60AqpNiUBiSZ7dSOoUiGWOk6fOU6NEKAqRS6LWQOU4DYMCgNNuzZXS4RnB7lIB4J ka+kxSNj0C6R1GL2psMaFdxI289jeuQJaO1ORqArINeaD+MOpaAiSYXk4dzrH/Iz6kZq M44r8JKsqApBBj4R4N0txX9AQgW2pTQHvgEdGeDT2lq/5Zdqkr2bdZPGyu0ijvI+t7FX r8vQQLGDWSuhrkvmkIuZKYmWrKGn3bqhxj09OXzKDfgVLAD6UBjElI1IvcfXQPQWBR9P tEprOO66oy769jzeRyaV+IJdPJSo6EMRbf+kpBiyitnGjWWNGmI+ysEUTjvNJsVuxMAj BJMQ== X-Forwarded-Encrypted: i=1; AKwUvBydAn5ulkPYPJntymTpEG+YTqSA0BbKhS8MimKFuGyQ4PfioSmc6AXT9yhjfCUQIINuwA6rc7Zaehs=@lists.infradead.org X-Gm-Message-State: AFq9FYIjaDrSJdFDhbrtYuFpekQnS0N7Spl3RUGH/I4V+IMqjeVt27di y/82im1i13HZtqFVav9AoPuU4VuXGQK3XjKsZ2BScfXOJs+3iYDQZ3RqrF0uwauCzd1FWhQvKSA j6PcyatADHKaPPtTN+MMJDM9VQ4k6f484UkQXkZdfY8ViIeaub/Jx0zOeSRAqpq9pRAWC X-Gm-Gg: AYBFou1ChkIaoHotGpUAKTEfq/GvRmZSj3ZbdNhaSuVGlG8YpfVTUDI9cUIJHkZv8pv kNkhaQHpMH6mGeqWmoCS1MBSDs55vHpeapvdE9GD5LZncN0mtDhWG0qm9btDiji3U9mH6b4y1TI yC8PF2bfxSeS3U1JTnRxTuuZLjDUp5olWePo1iIGgLFKVb2fG79oPivaOuaSle1gn1+eNhp9i2O ZkMLprOvDwSKncEd320LqCClvDzrTpt3Fd7nEUDy/U9WXRF7zIJu619mCB2pBHYjJ78NMddAE+K dD8Tg0OWmRmiSaH0PdVO1E3uKvZ9F4zeV2lSSgXy1Lr5JEeWHPGw8+X/nV1N7hkzGQvuW//WAEA q+uZ82edE8F7A X-Received: by 2002:a17:90b:3c05:b0:3a0:e5ed:ef99 with SMTP id 98e67ed59e1d1-3a0e5edf00bmr4635290a91.45.1790593027289; Mon, 28 Sep 2026 03:57:07 -0700 (PDT) X-Received: by 2002:a17:90b:3c05:b0:3a0:e5ed:ef99 with SMTP id 98e67ed59e1d1-3a0e5edf00bmr4635259a91.45.1790593026762; Mon, 28 Sep 2026 03:57:06 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0e7036e3bsm13347868a91.13.2026.09.28.03.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 03:57:06 -0700 (PDT) Date: Mon, 28 Sep 2026 16:26:59 +0530 From: Mohd Ayaan Anwar To: Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Bianconi , Shawn Guo , Zhangfei Gao Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add Nord compatible Message-ID: References: <20260923-nord_ethernet_serdes-v1-0-f8ac1c487882@oss.qualcomm.com> <20260923-nord_ethernet_serdes-v1-1-f8ac1c487882@oss.qualcomm.com> <20260928-gregarious-deft-boar-e776ae@quoll> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260928-gregarious-deft-boar-e776ae@quoll> X-Proofpoint-GUID: QwFA1INcWZ9YI3BfcKA3BR9-NEmVPPdI X-Proofpoint-ORIG-GUID: QwFA1INcWZ9YI3BfcKA3BR9-NEmVPPdI X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI4MDA0MyBTYWx0ZWRfX6hF1f21I7pyM bMTVYOtT5Xwq5LoxDTmgdtCdqnj49o1t09fG8RskLOQ8kekusQrYJgNEbSPcN/nC3Wk66OWpCv1 uz9Mx8xO/LOnPqfP7lzkWRjE/UkgyIA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI4MDA0MyBTYWx0ZWRfX3KND8N+UQbi4 s1kqPWqmqedwxj0qzmY+9jybpLPifVhpJDf4YE1jtpj8oxp5e2IN6nEULxLuPL1c5fjmq++cg2x IvC4ALQqUIKyjxTdGI1UlFRJGxyjebdFTLLDtOlJV4tFg422irfdZRyy+RGsHBXBQEyp2sJhCEW J8DzZpNSaI1PxlvNAWafIW6zqKHFmK4ImXyslDAwxXgW8OPN/MvcMFDrZ4JKaZARwOd5iJfWkl7 ytVKoUQI7cnouxmif6kQRIt2DyzM7UjcYw2/2pPwgo/rruCAHecw+4+8jth/gLtuZwlHTFpLUR4 xHqfu5pgwkdVjU41ESiwIPcvq2RrLxirlwi8o7rJvVw2Z2BvnKJ7dZs7DVJuz40bsufdJ9NtXQg K2/0Oj1ZHXhTM2f6/R5zK0WtXYvIonVUBiDxcXWV+QlWt5B2/TZyEg6pxE2kxoJl+6FsRBpJNNa TNnwJV7HeRQfmYR4ydg== X-Authority-Analysis: v=2.4 cv=QZfzLcbv c=1 sm=1 tr=0 ts=6aba4804 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=Sf7_UopSgax0LG51KRsA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-28_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 phishscore=0 impostorscore=0 suspectscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609280043 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260928_035710_678411_11AF4493 X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Sep 28, 2026 at 12:16:45PM +0200, Krzysztof Kozlowski wrote: > On Wed, Sep 23, 2026 at 05:34:17AM +0530, Mohd Ayaan Anwar wrote: > > Add the qcom,nord-dwmac-sgmii-phy compatible to the Qualcomm DWMAC > > SGMII PHY binding. > > Why random order? Why not enum with existing part? You are right. I will group the stanalone compatibles into a single enum and sort them alphabetically in v2. > Why not even compatible with existing device? Nord uses the QMP v7 SerDes register layout, whereas sa8775p uses the v5 layout. The offsets differ, so Nord cannot use qcom,sa8775p-dwmac-sgmii-phy as a fallback compatible. > > So many questions, yet commit msg copies subject. > Sorry about that. I mentioned the QMP v7 details in the cover letter but forgot to include them in the commit message. I will expand the commit message in v2 to describe the hardware differences and explain why there is no fallback compatible. Thank you for the review. Ayaan -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A6BB496D5E for ; Mon, 28 Sep 2026 10:57:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790593030; cv=none; b=ngx2c2c50HFdqluJKUaMP4fnzj5iM+i5IxVE7m8PZDZ+uPdyayV0vGM74F2JFCiSti1ymudoW/KYqtJmNJEOM0fODp532Hi1yxv6uLyLKmMKDNUcUZRTaLcGkb9VGWY9tsYJWZE8goqMtFR/KM31RRfYtq0cKPa4adsjVmWn13k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790593030; c=relaxed/simple; bh=D557zzr+WR/16Rt6Y0KG6Zy5JvNoW2oCPNoIqwlS7y8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fYez0C0MKY6y+5FqRWXrUBmzIMCikhbtSBranCnXazq7+zx7WiLmaQ4qSQtpS2Wx2TwXgF+Uf64RHfspeTru83QMcTZq3OEFPcYXp0SGqEDRbysUkupQQMl3vJZsHt4izuUD2nCeQI6YeGD/S+nmPxcTLsZOP2qFCuIkXvKvDto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jvnTlAw2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OqA3U2rR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jvnTlAw2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OqA3U2rR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68S9M8I2954231 for ; Mon, 28 Sep 2026 10:57:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=S4yLLM7uCYQket8rd9Pq6dEX 97HjH+y8AYJVBdz3Q0E=; b=jvnTlAw2/E+rAGs2X7Wvf5URybq+Oylk43sy41mz wrWJMQXat9HZPX6PbNjPv1nuHWWPzgdBijazlIbRtYOpBMWZWV8UDNm1iGKME9nk gSAgOULoCVQh7Mmzcwycyu3ceN7akynxUtzIA7RpqnvWLOq/sdW16xG0XqZPEIBU +1FH7Sb0SJFX4SYt0nEJ7AM/tFKv6By71Y6JeWO06Ah7Sib5rrfFezTgYwhcn0db p5IFQOF9fxBiYEPoG3T+Gzy7M53raHJzPXAflYqbhH39QdeFZCiW/w4s7tNrjMFp uO9aH07nUKiBd3s1SC+iPmKp6i8kyEjznziTOajnxmqK2A== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gynbc0ckc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 28 Sep 2026 10:57:08 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-398dcfabbf8so8581656a91.0 for ; Mon, 28 Sep 2026 03:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790593027; x=1791197827; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=S4yLLM7uCYQket8rd9Pq6dEX97HjH+y8AYJVBdz3Q0E=; b=OqA3U2rRcFmyfOtCsnuJRACpz5mfzrPzNjR24IkKisngGd2McJ66Wn7cbl6UQcdqSH n6h7dif7Nn+KLQcYtOj8kJKb8RKpC9QwwZHvziyJDSRBgBwxelbU7XdnBZbSEn9vz9KD zPYMRe2MQcuS9nnFAIdGEWT9QZiYFAjQV9hex1fU6l4XGFFBUxML+K4zqm8KJlD34SRP cJ17Y/qTgZyjqf8IG9Q175FYJF/BKepuiz9xBoTS/ddG2JhZaPkP8h8s8WpwrmsydjQp rbAluXEQ10xCzw72xd6zxiIF9u3ENfiXLeTCxkh/Z5kTQZammpfmwJwyS7pDFXCVgdtm mB+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790593027; x=1791197827; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S4yLLM7uCYQket8rd9Pq6dEX97HjH+y8AYJVBdz3Q0E=; b=ztkAmmrNIX6Fnj391Rtjr5KlXE/vYfEcxgaNukpFYarncMlDcfLb0ao9LbwuowXCjl axtY9zRENqbNvqHSj4LrNgNG8PqqkimpNKpDbN1XZuToWnrMNWdnnCuIO39iNVW1vOdh yARNJzeepmlAZYrBBdskf1IA0stIiPw9VKrvVhgDk0EpfcD0TJtRjCyyTiru87n3XK3k BfO+vA4nnZ4bNs86Fd/9kdfQ9DepBoseXPWissFzNB8FI1LI6VtDtp0gP12hxj3EAhys vbbf3NNWQ2VXE2limylle7Igu8Wg5eNlhrzYTA3qKRgeM6GMwDqW7GwrwpmOdMRGvSJZ 8daw== X-Forwarded-Encrypted: i=1; AKwUvBwaNfS7qrlo6EXUnMqSb4m8At4xqhOtZKzWJuDhNjtDdj5ILxZsa8ns6PE9cVxibGljUhf1I0EwiOdV@vger.kernel.org X-Gm-Message-State: AFq9FYIU07I01Gn29yn78EWh8H7G8D4JEme64c863zef6Q/IMlsPtMc9 I66QE5pGPMkokdUFvpq5ucTYxzDZ00EcWlq/5Ohw/ob67Ojv+X6VnL7cARFaSbdb3NjBVXxdo35 ADM9qykX7tNfd+B7AvKVjJIiQPyh+Ztq8Ph+DJ+4yGJiz0lDAYlg4rXOX+GRx6YUk6E+DFqlU X-Gm-Gg: AYBFou3cok4wlg3ufpen2eR51j8/Cy4sZTuTF5Mj4GZkv/1vAclwOptCCkgVSFDwdm/ RM/hDnJlX4wTfufY4d+kFxtQzK7a/lR69QVJydKMdeCZqWiATxXFjQX+y2BY2ZJDos32MhzPJ4G Fx/m/TSQTfbPkJ8ooUynQ7ipQAWPYlugZPR0g0FSIN/s8UpeeN6BX7/wfyWE9QR02ytJNymNiKe nLtnrm60e/TAhQS7mlyFcmdWDyEQKI+ENoIZAlSEK2/ixv5JOmOa+s47Hoh/OnyAnL3bbQU4aKB KH5550jnWAjEFRnnJ0NGeJYtggjOp7Bsl+1/Wr1ugMQ0ALoJ0O+m06UdvaAjgm38qvJjKzUPe0u imKIyOgEvgiFK X-Received: by 2002:a17:90b:3c05:b0:3a0:e5ed:ef99 with SMTP id 98e67ed59e1d1-3a0e5edf00bmr4635289a91.45.1790593027289; Mon, 28 Sep 2026 03:57:07 -0700 (PDT) X-Received: by 2002:a17:90b:3c05:b0:3a0:e5ed:ef99 with SMTP id 98e67ed59e1d1-3a0e5edf00bmr4635259a91.45.1790593026762; Mon, 28 Sep 2026 03:57:06 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a0e7036e3bsm13347868a91.13.2026.09.28.03.57.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Sep 2026 03:57:06 -0700 (PDT) Date: Mon, 28 Sep 2026 16:26:59 +0530 From: Mohd Ayaan Anwar To: Krzysztof Kozlowski Cc: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Lorenzo Bianconi , Shawn Guo , Zhangfei Gao Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add Nord compatible Message-ID: References: <20260923-nord_ethernet_serdes-v1-0-f8ac1c487882@oss.qualcomm.com> <20260923-nord_ethernet_serdes-v1-1-f8ac1c487882@oss.qualcomm.com> <20260928-gregarious-deft-boar-e776ae@quoll> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260928-gregarious-deft-boar-e776ae@quoll> X-Authority-Analysis: v=2.4 cv=Sq4Fe/O0 c=1 sm=1 tr=0 ts=6aba4804 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=Sf7_UopSgax0LG51KRsA:9 a=CjuIK1q_8ugA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: GIewXkHT1zAvJwghBvb5LShxU4uJrulA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI4MDA0MyBTYWx0ZWRfX6k6DyPDpNsMR LOHY4sOyYMa+1iU9474HrAmU8epGHu3F6QkcWW5uNGJqIPMWIuk2soIoOiRyb9OrUoIyStdN1t8 zvJ2rdvFTa6WSzxD9lKSPD8n0xRysY+JMZsH/X1X6IYIC25J8SRebtJ5d7La1EAYMJhTQ2tYNSl Hguk7qRWpWIVv6KcdNrYEdBLG7FdGF9kUi1uvQmgUOSBAZCLS/IFCxZn5NWLxMqJhl7dJx/yLYV I5DZLBAA/SK+QrN9m6s+Hc4ye0JmyAYTRJotaHJeqKokg/gwwN+PV++M5dLN47DQpqsUql6E8Iz sQMsbdyIhoX/THhqf8KsAI477+rKvBFJoYiBL/SXAPhOrp9sQy7ObHhPoyJMUo7bvF/DkEi9Y6S x5iY4TZNxWAEaF9sHVWG+a2sf2o0D0ntWQqcpaI32m518IRfc1Rx8rU0h3wCwpkiyobuOJF9/Sp x02KN/AMy+jgvuzaQUA== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI4MDA0MyBTYWx0ZWRfXx2FBqQ/8G8dS QFDncJK+vaMH3rq7Uzc2my8WrQAHFStEQimG6eRRtlYI3tcFly6T9zWIb/Lt6BygEVFyv9fEi7d iFs4s8Ie/SvPbc/EGqEhhu/Zo2rJfBQ= X-Proofpoint-ORIG-GUID: GIewXkHT1zAvJwghBvb5LShxU4uJrulA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-28_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609280043 On Mon, Sep 28, 2026 at 12:16:45PM +0200, Krzysztof Kozlowski wrote: > On Wed, Sep 23, 2026 at 05:34:17AM +0530, Mohd Ayaan Anwar wrote: > > Add the qcom,nord-dwmac-sgmii-phy compatible to the Qualcomm DWMAC > > SGMII PHY binding. > > Why random order? Why not enum with existing part? You are right. I will group the stanalone compatibles into a single enum and sort them alphabetically in v2. > Why not even compatible with existing device? Nord uses the QMP v7 SerDes register layout, whereas sa8775p uses the v5 layout. The offsets differ, so Nord cannot use qcom,sa8775p-dwmac-sgmii-phy as a fallback compatible. > > So many questions, yet commit msg copies subject. > Sorry about that. I mentioned the QMP v7 details in the cover letter but forgot to include them in the commit message. I will expand the commit message in v2 to describe the hardware differences and explain why there is no fallback compatible. Thank you for the review. Ayaan