From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf build: Clean libperf-gtk.so in 'make clean'
Date: Mon, 28 Sep 2026 18:54:41 +0200 [thread overview]
Message-ID: <arqb0dVg7hmdnI-r@x2> (raw)
In-Reply-To: <20260928163649.3463451-1-irogers@google.com>
On Mon, Sep 28, 2026 at 09:36:49AM -0700, Ian Rogers wrote:
> When GTK support was made opt-in (first via GTK2=1 and recently ported
> to GTK4=1), $(OUTPUT)libperf-gtk.so is only added to ALL_PROGRAMS when
> GTK4 is defined. As a result, running 'make clean' without GTK4=1 does
> not remove $(OUTPUT)libperf-gtk.so.
>
> Add $(OUTPUT)libperf-gtk.so explicitly to the core-progs clean list so
> it is always removed by 'make clean'.
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
prev parent reply other threads:[~2026-09-28 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 16:36 [PATCH v1] perf build: Clean libperf-gtk.so in 'make clean' Ian Rogers
2026-09-28 16:39 ` sashiko-bot
2026-09-28 16:54 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arqb0dVg7hmdnI-r@x2 \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.