From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
John Stultz <jstultz@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Christian Loehle <christian.loehle@arm.com>,
David Dai <david.dai@linux.dev>, Koba Ko <kobak@nvidia.com>,
Aiqun Yu <aiqun.yu@oss.qualcomm.com>,
Shuah Khan <shuah@kernel.org>,
Emil Tsalapatis <emil@etsalapatis.com>,
sched-ext@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET v14 sched_ext/for-7.4] sched: Make proxy execution compatible with sched_ext
Date: Mon, 28 Sep 2026 22:47:48 +0200 [thread overview]
Message-ID: <arrSdAzAUpkjbFng@gpd4> (raw)
In-Reply-To: <72d8d44fee50dc88f500bdb808eb21f6@kernel.org>
Hi Tejun,
On Mon, Sep 28, 2026 at 09:53:31AM -1000, Tejun Heo wrote:
> On Tue, Sep 22, 2026 at 06:51:39PM +0200, Andrea Righi wrote:
> > Andrea Righi (16):
> ...
> > sched_ext: Block proxy donors before taking control
> > sched_ext: Fix ops.running/stopping() pairing for proxy-exec donors
> > sched_ext: Move reject DSQ draining into core
> > sched_ext: Generalize the reject DSQ reenqueue path
> > sched_ext: Handle proxy-exec races in remote DSQ transfers
> > sched_ext: Split curr|donor references properly
> > sched_ext: Track proxy execution for NOHZ_FULL
> > sched_ext: Delegate proxy donor admission to BPF schedulers
> > sched_ext: Add selftest for blocked donor admission
> > sched_ext: scx_qmap: Add proxy execution support
> > sched: Allow enabling proxy exec with sched_ext
>
> Applied 6-16 to sched_ext/for-7.4 on top of tip/sched/core (be100c77178e)
> with the following conflict resolutions:
>
> - 07: sched/core's c72945693b90 ("sched: Restart fair hrtick after same-task
> repicks") changed set_next_task_scx() to take enum snt_e. @first is now
> derived as type == SNT_PICK. SNT_REPICK returns early as before.
>
> - 08: for-7.4's 7a919c7f86de ("sched_ext: Test scx_has_subs() inline before
> calling sub-sched hooks") split scx_reenq_reject() into an inline wrapper
> and __scx_reenq_reject(). Moved the combined function into ext.c and
> dropped both from sub.h.
>
> - 08, 09, 10: Kept scx_reenq_wait_dispatching() from 7de9a6fb44ea
> ("sched_ext: Wait for SCX_OPSS_DISPATCHING before reenqueueing a task") in
> reenq_local() and scx_reenq_reject(), after the new proxy retry checks.
>
> - 10: be100c77178e already has the fixed scx_proxy_reenqueue_retry()
> signature, so only the body was applied. The rq_owned_post_enq() comment
> update was applied over the context changed by cb86607ada73 ("sched_ext:
> Don't run ops.dequeue() with a DSQ lock held").
>
> - 11: Context only, the can_stop_tick declaration in set_next_task_scx() and
> the rq->donor change in scx_rescue_timerfn().
>
> - 14: Context only, enq_blocked in the selftest Makefile.
>
> - 15: dispatch_to_rescue() inserts without needs_immed() per a0d356696f87
> ("sched_ext: scx_qmap: Do not add IMMED to rescue inserts"), and the
> rescue comment keeps the for-7.4 text.
>
> Can you please verify the result?
I reran all my proxy-exec tests on sched_ext/for-7.4. The conflict resolutions
look good. The only issues I saw were unrelated virtio console warnings while
testing inside virtme-ng, fixed by:
b144dc5a2414 ("virtio_console: allocate the port_buffer with the caller's gfp")
Otherwise, everything works great!
Thanks,
-Andrea
prev parent reply other threads:[~2026-09-28 20:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 16:51 [PATCHSET v14 sched_ext/for-7.4] sched: Make proxy execution compatible with sched_ext Andrea Righi
2026-09-22 16:51 ` [PATCH 01/16] sched/core: Drop mutex locks before proxy rescheduling Andrea Righi
2026-09-22 16:51 ` [PATCH 02/16] sched/core: Dequeue waking proxy donors before reset Andrea Righi
2026-09-22 16:51 ` [PATCH 03/16] sched/core: Mark wakeups completed through ttwu_runnable() Andrea Righi
2026-09-22 16:51 ` [PATCH 04/16] sched: Add helper to block retained proxy donors Andrea Righi
2026-09-22 16:51 ` [PATCH 05/16] sched: Add sched_ext hooks for proxy execution Andrea Righi
2026-09-24 7:51 ` Peter Zijlstra
2026-09-25 8:23 ` Andrea Righi
2026-09-22 16:51 ` [PATCH 06/16] sched_ext: Block proxy donors before taking control Andrea Righi
2026-09-22 16:51 ` [PATCH 07/16] sched_ext: Fix ops.running/stopping() pairing for proxy-exec donors Andrea Righi
2026-09-22 16:51 ` [PATCH 08/16] sched_ext: Move reject DSQ draining into core Andrea Righi
2026-09-22 16:51 ` [PATCH 09/16] sched_ext: Generalize the reject DSQ reenqueue path Andrea Righi
2026-09-22 16:51 ` [PATCH 10/16] sched_ext: Handle proxy-exec races in remote DSQ transfers Andrea Righi
2026-09-22 16:51 ` [PATCH 11/16] sched_ext: Split curr|donor references properly Andrea Righi
2026-09-22 16:51 ` [PATCH 12/16] sched_ext: Track proxy execution for NOHZ_FULL Andrea Righi
2026-09-22 16:51 ` [PATCH 13/16] sched_ext: Delegate proxy donor admission to BPF schedulers Andrea Righi
2026-09-22 16:51 ` [PATCH 14/16] sched_ext: Add selftest for blocked donor admission Andrea Righi
2026-09-22 16:51 ` [PATCH 15/16] sched_ext: scx_qmap: Add proxy execution support Andrea Righi
2026-09-22 16:51 ` [PATCH 16/16] sched: Allow enabling proxy exec with sched_ext Andrea Righi
2026-09-24 7:52 ` [PATCHSET v14 sched_ext/for-7.4] sched: Make proxy execution compatible " Peter Zijlstra
2026-09-24 7:59 ` Peter Zijlstra
2026-09-24 8:10 ` K Prateek Nayak
2026-09-24 9:09 ` Peter Zijlstra
2026-09-25 7:46 ` Andrea Righi
2026-09-25 7:56 ` Peter Zijlstra
2026-09-26 19:17 ` Tejun Heo
2026-09-28 19:53 ` Tejun Heo
2026-09-28 20:47 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arrSdAzAUpkjbFng@gpd4 \
--to=arighi@nvidia.com \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=christian.loehle@arm.com \
--cc=david.dai@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=emil@etsalapatis.com \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=kobak@nvidia.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.