From: Pranjal Shrivastava <praan@google.com>
To: Mostafa Saleh <smostafa@google.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, will@kernel.org,
robin.murphy@arm.com, joro@8bytes.org, jgg@ziepe.ca,
nicolinc@nvidia.com
Subject: Re: [PATCH v2 3/5] iommu/arm-smmu-v3-test: Add missing error checks for inv array
Date: Tue, 29 Sep 2026 00:02:01 +0000 [thread overview]
Message-ID: <arr_-bvl3qGR14BZ@google.com> (raw)
In-Reply-To: <20260924085616.300650-4-smostafa@google.com>
On Thu, Sep 24, 2026 at 08:56:14AM +0000, Mostafa Saleh wrote:
> arm_smmu_invs_merge() and arm_smmu_invs_alloc() can return NULL or
> errors which are checked by the driver but not the test.
>
> Add KUNIT_ASSERT_NOT_ERR_OR_NULL() after calling them to fail the
> test instead of accessing NULL or ERR pointers.
>
> Fixes: 15a2a5645ad7 ("iommu/arm-smmu-v3: Introduce a per-domain arm_smmu_invs array")
> Reported-by: Sashiko <>
> Signed-off-by: Mostafa Saleh <smostafa@google.com>
Reviewed-by: Pranjal Shrivastava <praan@google.com>
Thanks,
Praan
next prev parent reply other threads:[~2026-09-29 0:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 8:56 [PATCH v2 0/5] iommu/arm-smmu-v3: Fixes reported by Sashiko Mostafa Saleh
2026-09-24 8:56 ` [PATCH v2 1/5] iommu/arm-smmu-v3: Ensure L2 tables are visible before L1 ptrs Mostafa Saleh
2026-09-28 23:59 ` Pranjal Shrivastava
2026-09-24 8:56 ` [PATCH v2 2/5] iommu/arm-smmu-v3-test: Fix arm_smmu_v3_test_debug_print_used_bits() Mostafa Saleh
2026-09-29 0:00 ` Pranjal Shrivastava
2026-09-24 8:56 ` [PATCH v2 3/5] iommu/arm-smmu-v3-test: Add missing error checks for inv array Mostafa Saleh
2026-09-29 0:02 ` Pranjal Shrivastava [this message]
2026-09-24 8:56 ` [PATCH v2 4/5] iommu/arm-smmu-v3-test: Fix OOB in arm_smmu_v3_invs_test_verify() Mostafa Saleh
2026-09-29 0:02 ` Pranjal Shrivastava
2026-09-24 8:56 ` [PATCH v2 5/5] iommu/arm-smmu-v3-test: Fix UBSAN error Mostafa Saleh
2026-09-29 0:03 ` Pranjal Shrivastava
2026-09-24 18:34 ` [PATCH v2 0/5] iommu/arm-smmu-v3: Fixes reported by Sashiko Jason Gunthorpe
2026-09-24 18:58 ` Nicolin Chen
2026-10-02 16:46 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arr_-bvl3qGR14BZ@google.com \
--to=praan@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=smostafa@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.