From: Dan Carpenter <error27@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ricardo Ribalda <ribalda@chromium.org>,
Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>, Yunke Cao <yunkec@google.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Fix buffer overflow in uvc_mapping_get_menu_value()
Date: Tue, 29 Sep 2026 08:29:56 +0300 [thread overview]
Message-ID: <artM1Kqi41JfNSGg@stanley.mountain> (raw)
In-Reply-To: <20260928203105.GJ4406@killaraus.ideasonboard.com>
On Mon, Sep 28, 2026 at 11:31:05PM +0300, Laurent Pinchart wrote:
> On Fri, Sep 18, 2026 at 03:20:25PM +0300, Dan Carpenter wrote:
> > The "idx" value is a user controlled u32 so we have to bounds check it
> > before calling test_bit() to avoid reading beyond the end of the bitmap.
> >
> > Fixes: 4e15c535659b ("media: uvcvideo: Support any size for mapping get/set")
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> What's the status of this patch ? The issue is a false positive, do you
> still think there's value in this redundant test ?
>
No, it's a false positive.
With how Smatch works, I don't have an easy way to silence it in Smatch,
but I'm going to publish my AI skills file for reviewing static checker
warnings. Also I've started writing a new tool to help filter false
positives.
regards,
dan carpenter
next prev parent reply other threads:[~2026-09-29 5:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 12:20 [PATCH] media: uvcvideo: Fix buffer overflow in uvc_mapping_get_menu_value() Dan Carpenter
2026-09-18 12:59 ` Ricardo Ribalda
2026-09-18 13:18 ` Dan Carpenter
2026-09-18 13:46 ` Ricardo Ribalda
2026-09-18 16:15 ` Dan Carpenter
2026-09-28 20:31 ` Laurent Pinchart
2026-09-29 5:29 ` Dan Carpenter [this message]
2026-10-08 6:47 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=artM1Kqi41JfNSGg@stanley.mountain \
--to=error27@gmail.com \
--cc=hansg@kernel.org \
--cc=hverkuil@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=yunkec@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.