Re: [PATCH 2/2] dt-bindings: sound: tegra-ahub: Convert to json-schema

[Thierry Reding <thierry.reding@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2969 bytes --]

On Mon, Sep 28, 2026 at 04:46:15PM -0500, Rob Herring wrote:
> On Mon, Sep 28, 2026 at 06:24:41PM +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> > 
> > Convert Tegra AHUB bindings from the free-form text format to
> > json-schema.
> 
> Pretty sure there was a prior version posted... Please check any 
> comments there.

I thought so, too, but when I searched lore I could find any references.

[...]
> > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml
> > new file mode 100644
> > index 000000000000..c064a2acae5e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.yaml
> > @@ -0,0 +1,260 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/nvidia,tegra30-ahub.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NVIDIA Tegra30 AHUB (Audio Hub)
> > +
> > +maintainers:
> > +  - Thierry Reding <thierry.reding@gmail.com>
> > +  - Jon Hunter <jonathanh@nvidia.com>
> > +
> > +description: AHUB client modules need to specify the IDs of their CIFs (Client InterFaces). For RX
> > +  CIFs, the numbers indicate the register number within AHUB routing register space (APBIF 0..3 RX,
> > +  I2S 0..5 RX, DAM 0..2 RX 0..1, SPDIF RX 0..1). For TX CIFs, the numbers indicate the bit position
> > +  within the AHUB routing registers (APBIF 0..3 TX, I2S 0..5 TX, DAM 0..2 TX, SPDIF TX 0..1).
> 
> CR after 'description' and rewrap to 80 chars.

Sure.

> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - nvidia,tegra30-ahub
> > +      - nvidia,tegra114-ahub
> > +      - nvidia,tegra124-ahub
> > +
> > +  reg:
> > +    minItems: 2
> > +    maxItems: 3
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    items:
> > +      - description: digital audio clock
> > +      - description: module clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: d_audio
> > +      - const: apbif
> > +
> > +  resets:
> > +    minItems: 11
> > +    maxItems: 21
> > +
> > +  reset-names:
> > +    minItems: 11
> > +    maxItems: 21
> > +
> > +  ranges: true
> > +
> > +  dmas:
> > +    minItems: 8
> > +    maxItems: 20
> > +
> > +  dma-names:
> > +    minItems: 8
> > +    maxItems: 20
> > +
> > +  "#address-cells":
> > +    enum: [ 1, 2 ]
> > +
> > +  "#size-cells":
> > +    enum: [ 1, 2 ]
> > +
> > +patternProperties:
> > +  "^i2s@[0-9a-f]+$":
> > +    type: object
> 
>        required:
>          - compatible
> 
> Otherwise, we can't be sure it is validated. Or if there isn't a 
> compatible, then the schema needs to go here (directly or via a $ref).

Good point. These do have compatible strings, so I'll add the required
here.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]