From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24A60C9832A for ; Tue, 29 Sep 2026 15:04:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xBZNF-0006kH-Pd; Tue, 29 Sep 2026 11:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBZND-0006k4-HD for qemu-devel@nongnu.org; Tue, 29 Sep 2026 11:04:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xBZNB-0005GK-WF for qemu-devel@nongnu.org; Tue, 29 Sep 2026 11:04:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790694241; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ic7CLa3g5+1fbTR+W1wVAVjn7R/RnrL35OL4I8BpD6A=; b=X5uAEUfrOgljP67saooVZ6sqs4RTOYAc7Y4+fKUSR5hJgaWbACiC23yDF6S+DX8vG6vS2s h9SZWhbRNzsJ/vtB9cig9eT09l9P3g3Lt0SBsFiIQPZRQWKzig27f9ykHu/0NpTKTyt7nq d1DhM9ThxvOsieR1BR3yw/ujge0ARwI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-ZJ217PjHPZO1_lk5T6Dqag-1; Tue, 29 Sep 2026 11:03:53 -0400 X-MC-Unique: ZJ217PjHPZO1_lk5T6Dqag-1 X-Mimecast-MFC-AGG-ID: ZJ217PjHPZO1_lk5T6Dqag_1790694233 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 047C3187A5D4; Tue, 29 Sep 2026 15:03:53 +0000 (UTC) Received: from redhat.com (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E75911956045; Tue, 29 Sep 2026 15:03:51 +0000 (UTC) Date: Tue, 29 Sep 2026 16:03:49 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Roman Bogorodskiy Cc: qemu-devel@nongnu.org, Kostiantyn Kostiuk , Michael Roth Subject: Re: [PATCH v2] tests/unit/test-qga: enable on FreeBSD Message-ID: References: <20260929150100.66035-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260929150100.66035-1-bogorodskiy@gmail.com> User-Agent: Mutt/2.4.0 (2026-06-19) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.341, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Sep 29, 2026 at 05:01:00PM +0200, Roman Bogorodskiy wrote: > FreeBSD has all necessary commands implemented, > so enable test-qga for it. > > Requires only minimal portability fixes for sockets > in connect_qga(). > > Signed-off-by: Roman Bogorodskiy > Reviewed-by: Kostiantyn Kostiuk > --- > Changes since v1: > > - Drop SUN_LEN() for 'len' calculation on FreeBSD, > use 'len = sizeof(remote)' on all platforms. Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|