From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f41.google.com (mail-wr2-f41.google.com [74.125.225.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EAB3CA491 for ; Tue, 29 Sep 2026 15:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.105 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790695831; cv=none; b=Jm8ROAvUOQbK/o8OcJ63ZiOquRcymIxqwhy2uSEqQW40vPcelYoBHtoN+u58C9amyPW39TCuLxv7e+G9w4ENxh0A/9ftNmIuzKUTJvciiczM80pGPKS3U6VTBnM+Nzhb3Ge9LbPAtz7vou5JfYNGwYAvHJ6Bgxa1St2R3F8oFVo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790695831; c=relaxed/simple; bh=F4vwzsAv5drBYD3qzwjgWR2J9+Uw6/OSFUG7o1trW1s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NHvwzYay8CJs+dFb9PZ+S0Ojarx01OX0XJ7C31hdSKAVxca/1r1T6YbgVkwGsTac82KQmOLPEKM6TxorFOlezLZDveObOP3296oEHX93oVPAosbNq6/slQauKbK15pcCpn5LGzxlZOCVEpGKeDs6HrEmnWLjfB1DH43PeqpHPqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=Ia0fNy+g; arc=none smtp.client-ip=74.125.225.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="Ia0fNy+g" Received: by mail-wr2-f41.google.com with SMTP id ffacd0b85a97d-4834977ae75so2619916f8f.3 for ; Tue, 29 Sep 2026 08:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1790695827; x=1791300627; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WyDJvPwiURiXggZLxrM4rW7PJScAxLcWq9jkvSmb68E=; b=Ia0fNy+g9yzZ+Pw523i8UgyZHcJ+BoCzNGcM8SKXNyz8VqVp8cL8U2nn90MKMi3sX3 mvXM4A5oQq4vj0u4bQMRLkeYL26lxE+//KhGXm4BeFGAjTiFNh4lG9397nCMzyhV795M Rdp3/xQ7Q26XD6DtpALRkj1p+ekol8Lmqnbr6poyz6roLgb+JojPWIrhRglcc/EmYAA+ QdiSFX13YJ+o4mIEj05nZa10a3JGltxd7nk+Sxt6xJeVaikZJlTA0+YY5eDEOQlRLGrQ Jvwtm6BzMKEZu9VyBtZaMGQDv/4H3Zxqlo0z3G32qkYZ333vTQ6Y8ZqMaDa5xXpCAslD wWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790695827; x=1791300627; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WyDJvPwiURiXggZLxrM4rW7PJScAxLcWq9jkvSmb68E=; b=dsdh+9fzZmHsVCnaxJ8NRyRyThDdKjaO/n3C+rmgngTnFoKx8PyCk1ZRUX1ALX/qge EjeK+yAr646hhQi73+Db0Zk56FrS7Lri73a1PGQ8pFH8H8dFIgX4Vf7Bjb1+ANM1tXd6 o49/zRr5UfMvw8qEfaqgLwegTOqLqHF5LQCX/jseoB2bbnwDuzlytP48k4u1rbFRP8c3 JNyK2yl5PIHOMrYHZb9aTX9fTopoGHniAuVvn8vTqDKUWPvH17J/klkqQ7PVTxXQrAGg m5PsZlmhCWKx53Z74h/v+EWpFcikpvI+3HZoIS6l0qWX5v4A3WEn0qb0Y7YUaH/pjLAt 2Eww== X-Forwarded-Encrypted: i=1; AKwUvByZ6CDpT1jsusKr4loPv+xRLyvoYi2J80brRDx6waOzJuT1aFSrW93zOMc4ybRWQiawqtC4hxxQ9OjX@vger.kernel.org X-Gm-Message-State: AFq9FYIbJjZYtnVMzj9YJOjKSYyJibFN9GVNUz/tB2UtQu9m9FKJtvBn MnMrTC3a0oLNdr7IO0upYHSK+zcwSSPoM7e3s9HuLMuz5oy28ZmHJMIqv43nl+M/sQE= X-Gm-Gg: AYBFou2bAE3DZCu35dmu+2CxKMSP6Rg17UAPRVhAPxMBuIxftdhOwF/v97MlUKaR8M7 22SO4lpjaLfpJF1x3vIwt+9gZue1ZY14dco1305GxdpdQFIBxJkSdazgrFldDcwluZUVepKX4X7 pDjJaNtK4zcNrGN4hZcyf16eUQdx+bTt/lb6r5CLZaV6MH/wxf9NTw8zzVV85j4Pu4clL3hblDD aEJlfE/1EGIe2TjMmeatFcXQZvz6ZKVAGJtlBEaczxEWYtOzoCSRJ8Ij0SXZEnaWUw0D/uQHyDi 8ITtf1SUQXNeIVCCp90s1Rris+D4MJTkwO36v92ML2yWilnxOMU1F+mnYOWjWILi5kllJcOd8cV mRdOA8WjHwc+06WjEIPHxftO2XjDa+YtNkDqyeusbw1jRLWlZ7fheou8sIdnKs9XiME1Qy4MbHG 4h4NQhqyKbX4t3Fm1xC24DA5+yTb0DRW6QydGnlG+7j83RJRZ2axKN8a+mdnWbWEQy+o42KM88M 9kbHrdqni/6Q4dsYEqRd9/JGWk9/u6QVn6FDCSPZPgeXblAl8SdUUayRA31OXNR86JSZU2C X-Received: by 2002:a5d:6f0d:0:b0:488:8131:c684 with SMTP id ffacd0b85a97d-48af171b851mr6071142f8f.13.1790695827301; Tue, 29 Sep 2026 08:30:27 -0700 (PDT) Received: from localhost (p200300f65f19a904123cb16e9a8bb736.dip0.t-ipconnect.de. [2003:f6:5f19:a904:123c:b16e:9a8b:b736]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-48af4f88352sm5171032f8f.4.2026.09.29.08.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2026 08:30:26 -0700 (PDT) Date: Tue, 29 Sep 2026 17:30:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Josef Schlehofer Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Pali =?utf-8?B?Um9ow6Fy?= , Marek =?utf-8?B?QmVow7pu?= , Andy Shevchenko , Rong Zhang , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] leds: Add support for Turris 1.x LEDs Message-ID: References: <20260928111907.72592-1-pepe.schlehofer@gmail.com> <20260928111907.72592-3-pepe.schlehofer@gmail.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gf6rtofzqt35lkym" Content-Disposition: inline In-Reply-To: <20260928111907.72592-3-pepe.schlehofer@gmail.com> --gf6rtofzqt35lkym Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Subject: Re: [PATCH v3 2/2] leds: Add support for Turris 1.x LEDs MIME-Version: 1.0 Hello, On Mon, Sep 28, 2026 at 01:19:07PM +0200, Josef Schlehofer wrote: > [...] > +#include Please don't include . This is a header that pulls in a plethora of dependencies on subsystems you don't need in your driver. So either rely on to pull in the definition of of_device_id (my preferred option) or include if you want full iwyu. > +#include > +#include > +#include > [...] > +static void turris1x_leds_shutdown(struct platform_device *pdev) > +{ > + turris1x_leds_reset(platform_get_drvdata(pdev)); Is this needed to ensure a proper shutdown? If not I'd expect this shouldn't be done. > +} > + > +static const struct of_device_id of_turris1x_leds_match[] = { > + { .compatible = "cznic,turris1x-leds" }, > + {} { } please to match the most common style. > +}; > +MODULE_DEVICE_TABLE(of, of_turris1x_leds_match); Best regards Uwe --gf6rtofzqt35lkym Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmq72Y4ACgkQj4D7WH0S /k5KnAgAhZtJJoXqunj2x2oJQnmSxm/PEMoRlwQyPhfFAx2hve16++ANVtEO/Ezs 69fImgBN+zPW4Ueuwzlh+LhhIAlzzkOfP+nfg5lY4m74PrhR2N4QxRCUI9H92e2J igSY1goMilkzXCBvoCmGtqDK0WlGutBJINqBhj7B0EA+2VSzyLzyKvsF+ODcFlx9 lEisDl45mzbd+KX/WAnRQb8UghxxeIR1N1D/anut+YCU+wEX7Bk8quHAb+xx8QnB eLG/jzOSdS2MqvwA3W4A7Y+rYmiY09xJcqtGGC7lMGz7lAwZilYy1kFl8FMlCsfs KJL63mPnhbokMwEmeTCXtnL3QObeMA== =YuO2 -----END PGP SIGNATURE----- --gf6rtofzqt35lkym--