From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] clk: qcom: Add lpass audio clock controller driver for Glymur
Date: Tue, 29 Sep 2026 17:37:00 +0200 [thread overview]
Message-ID: <arvaq9M5aO7RVYSl@monoceros> (raw)
In-Reply-To: <20260922184425.56114-4-srinivas.kandagatla@oss.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 608 bytes --]
Hello,
On Tue, Sep 22, 2026 at 07:44:24PM +0100, Srinivas Kandagatla wrote:
> +#include <linux/clk-provider.h>
> +#include <linux/err.h>
> +#include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
Please don't use <linux/mod_devicetable.h>. That pulls in many unneeded
dependencies and I'm working on getting rid of it.
Just rely on <linux/platform_device.h> to provide of_device_id
(preferred), or include <linux/device-id/of.h> if you want to go full
iwyu.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
next prev parent reply other threads:[~2026-09-29 15:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 18:44 [PATCH 0/4] clk: qcom: Add LPASS clock/reset controllers for Glymur Srinivas Kandagatla
2026-09-22 18:44 ` [PATCH 1/4] dt-bindings: clock: Add LPASS AUDIOCC and reset controller " Srinivas Kandagatla
2026-09-22 18:54 ` sashiko-bot
2026-09-22 19:05 ` Srinivas Kandagatla
2026-09-28 9:59 ` Krzysztof Kozlowski
2026-09-28 10:00 ` Srinivas Kandagatla
2026-09-22 18:44 ` [PATCH 2/4] dt-bindings: clock: Add LPASSCC " Srinivas Kandagatla
2026-09-28 9:59 ` Krzysztof Kozlowski
2026-09-22 18:44 ` [PATCH 3/4] clk: qcom: Add lpass audio clock controller driver " Srinivas Kandagatla
2026-09-22 18:53 ` sashiko-bot
2026-09-22 20:40 ` Abel Vesa
2026-09-24 9:02 ` Taniya Das
2026-09-29 15:37 ` Uwe Kleine-König [this message]
2026-09-22 18:44 ` [PATCH 4/4] clk: qcom: Add lpass " Srinivas Kandagatla
2026-09-22 20:41 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arvaq9M5aO7RVYSl@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=srinivas.kandagatla@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.