From: "Lorenzo Stoakes (ARM)" <ljs@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
Fuad Tabba <fuad.tabba@linux.dev>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 04/11] kselftest/arm64: Use exit_error() rather than SIGABRT in fp-stress
Date: Tue, 29 Sep 2026 17:31:47 +0100 [thread overview]
Message-ID: <arvmJ50r86WCk9RY@gremlin> (raw)
In-Reply-To: <20260901-arm64-fp-stress-kvm-v1-4-31bce995b49b@kernel.org>
On Tue, Sep 01, 2026 at 06:06:44PM +0100, Mark Brown wrote:
> The fp-stress test loads all deliver a SIGABRT to the process group to
> report some errors they detect. There is no particular reason to use
> this mechanism over exiting with an error code, the fp-stress harness does
> not care. In order to facilitate running as KVM guests replace this with
> use of the exit_error() function we added.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
LGTM, so:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/arm64/fp/fpsimd-test.S | 10 ++--------
> tools/testing/selftests/arm64/fp/sve-test.S | 10 ++--------
> tools/testing/selftests/arm64/fp/za-test.S | 10 ++--------
> tools/testing/selftests/arm64/fp/zt-test.S | 8 +-------
> 4 files changed, 7 insertions(+), 31 deletions(-)
>
> diff --git a/tools/testing/selftests/arm64/fp/fpsimd-test.S b/tools/testing/selftests/arm64/fp/fpsimd-test.S
> index 5ee8ef51ea4e..fcbb3a872490 100644
> --- a/tools/testing/selftests/arm64/fp/fpsimd-test.S
> +++ b/tools/testing/selftests/arm64/fp/fpsimd-test.S
> @@ -176,7 +176,7 @@ function setsignal
> cbz w0, 1f
>
> puts "sigaction failure\n"
> - b .Labort
> + b exit_error
>
> 1: ldr x30, [sp], #((sa_sz + 15) / 16 * 16 + 16)
> ret
> @@ -224,7 +224,7 @@ function _start
> 1: puts "Bad vector length: "
> mov x0, x19
> bl putdecn
> - b .Labort
> + b exit_error
>
> 2: puts "Vector length:\t"
> mov x0, x19
> @@ -266,12 +266,6 @@ function _start
>
> add x22, x22, #1
> b .Ltest_loop
> -
> -.Labort:
> - mov x0, #0
> - mov x1, #SIGABRT
> - mov x8, #__NR_kill
> - svc #0
> endfunction
>
> function barf
> diff --git a/tools/testing/selftests/arm64/fp/sve-test.S b/tools/testing/selftests/arm64/fp/sve-test.S
> index 3447fe0e5554..26efdbdd88f9 100644
> --- a/tools/testing/selftests/arm64/fp/sve-test.S
> +++ b/tools/testing/selftests/arm64/fp/sve-test.S
> @@ -344,7 +344,7 @@ function setsignal
> cbz w0, 1f
>
> puts "sigaction failure\n"
> - b .Labort
> + b exit_error
>
> 1: ldr x30, [sp], #((sa_sz + 15) / 16 * 16 + 16)
> ret
> @@ -397,7 +397,7 @@ function _start
> 1: puts "Bad vector length: "
> mov x0, x19
> bl putdecn
> - b .Labort
> + b exit_error
>
> 2: puts "Vector length:\t"
> mov x0, x19
> @@ -474,12 +474,6 @@ function _start
>
> add x22, x22, #1
> b .Ltest_loop
> -
> -.Labort:
> - mov x0, #0
> - mov x1, #SIGABRT
> - mov x8, #__NR_kill
> - svc #0
> endfunction
>
> function barf
> diff --git a/tools/testing/selftests/arm64/fp/za-test.S b/tools/testing/selftests/arm64/fp/za-test.S
> index 33dc4ce8bfa1..7208bb2db9f1 100644
> --- a/tools/testing/selftests/arm64/fp/za-test.S
> +++ b/tools/testing/selftests/arm64/fp/za-test.S
> @@ -189,7 +189,7 @@ function setsignal
> cbz w0, 1f
>
> puts "sigaction failure\n"
> - b .Labort
> + b exit_error
>
> 1: ldr x30, [sp], #((sa_sz + 15) / 16 * 16 + 16)
> ret
> @@ -240,7 +240,7 @@ function _start
> 1: puts "bad vector length: "
> mov x0, x19
> bl putdecn
> - b .Labort
> + b exit_error
>
> 2: puts "vector length:\t"
> mov x0, x19
> @@ -288,12 +288,6 @@ function _start
>
> add x22, x22, #1 // Everything still working
> b .Ltest_loop
> -
> -.Labort:
> - mov x0, #0
> - mov x1, #SIGABRT
> - mov x8, #__NR_kill
> - svc #0
> endfunction
>
> function barf
> diff --git a/tools/testing/selftests/arm64/fp/zt-test.S b/tools/testing/selftests/arm64/fp/zt-test.S
> index c67242c2d5ab..c6cfbdeb2f0c 100644
> --- a/tools/testing/selftests/arm64/fp/zt-test.S
> +++ b/tools/testing/selftests/arm64/fp/zt-test.S
> @@ -158,7 +158,7 @@ function setsignal
> cbz w0, 1f
>
> puts "sigaction failure\n"
> - b .Labort
> + b exit_error
>
> 1: ldr x30, [sp], #((sa_sz + 15) / 16 * 16 + 16)
> ret
> @@ -222,12 +222,6 @@ function _start
>
> add x22, x22, #1 // Everything still working
> b .Ltest_loop
> -
> -.Labort:
> - mov x0, #0
> - mov x1, #SIGABRT
> - mov x8, #__NR_kill
> - svc #0
> endfunction
>
> function barf
>
> --
> 2.47.3
>
--
Cheers, Lorenzo
next prev parent reply other threads:[~2026-09-29 16:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 17:06 [PATCH 00/11] kselftest/arm64: Add coverage of interactions with KVM to fp-stress Mark Brown
2026-09-01 17:06 ` [PATCH 01/11] kselftest/arm64: Factor Linux syscalls out of asm-utils.S Mark Brown
2026-09-29 16:01 ` Lorenzo Stoakes (ARM)
2026-09-01 17:06 ` [PATCH 02/11] kselftest/arm64: Factor shared signal handlers out of fp-stress loads Mark Brown
2026-09-29 16:07 ` Lorenzo Stoakes (ARM)
2026-09-01 17:06 ` [PATCH 03/11] kselftest/arm64: Move exit calls " Mark Brown
2026-09-29 16:22 ` Lorenzo Stoakes (ARM)
2026-09-29 21:56 ` Mark Brown
2026-09-30 8:41 ` Lorenzo Stoakes (ARM)
2026-09-29 16:27 ` Mark Rutland
2026-09-29 22:03 ` Mark Brown
2026-09-30 8:51 ` Mark Rutland
2026-09-01 17:06 ` [PATCH 04/11] kselftest/arm64: Use exit_error() rather than SIGABRT in fp-stress Mark Brown
2026-09-29 16:28 ` Mark Rutland
2026-09-29 16:31 ` Lorenzo Stoakes (ARM) [this message]
2026-09-01 17:06 ` [PATCH 05/11] kselftest/arm64: Exit with an error code on data mismatches " Mark Brown
2026-09-29 16:37 ` Lorenzo Stoakes (ARM)
2026-09-01 17:06 ` [PATCH 06/11] kselftest/arm64: Factor startup code out of fp-stress load programs Mark Brown
2026-09-30 12:39 ` Lorenzo Stoakes (ARM)
2026-09-01 17:06 ` [PATCH 07/11] kselftest/arm64: Remove the sched_yield()s from the fp-stress loads Mark Brown
2026-09-30 14:17 ` Lorenzo Stoakes (ARM)
2026-09-01 17:06 ` [PATCH 08/11] kselftest/arm64: Add a very simple VMM for use in fp-stress Mark Brown
2026-09-01 17:06 ` [PATCH 09/11] kselftest/arm64: Build KVM guest versions of the fp-stress loads Mark Brown
2026-09-01 17:06 ` [PATCH 10/11] kselftest/arm64: Use execv() to start fp-stress test loads Mark Brown
2026-09-01 17:06 ` [PATCH 11/11] kselftest/arm64: Run KVM guests from fp-stress Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arvmJ50r86WCk9RY@gremlin \
--to=ljs@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.