All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent Jardin via buildroot <buildroot@buildroot.org>
To: Thibaut Collet <thbt.cllt@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/lldpd: fix compilation issue with kernel 7.3 on aarch64
Date: Tue, 29 Sep 2026 19:05:12 +0200	[thread overview]
Message-ID: <arvvyLRIyf-OFC3G@L30177.local> (raw)
In-Reply-To: <CABH27u-M+7Cn0MiQRtaZfv7mSwq3sG_1h-Pd5v7ooNTNgcU-+A@mail.gmail.com>

Hi Thibaut,

> So removing the uapi include files of lldpd to use the kernel ones is the
> best choice for kernel greater or equal to 4.19 to avoid using outdated
> include files regarding the kernel version.
> Gating the LLDPD_POST_PATCH_HOOKS with 'ifeq
> ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19),y)' will do the job.
> Do you agree with this solution ?

It seems to be a better approach for me.

> 
> Regarding Vincent question:
> 
> > However, could the lldpd's build framework be updated too with a mean to
> avoid such patch ?
> 
> As spotted in the commit log of lldpd use the right header files to be
> compliant with any kernel version and distribution is an endless loop. For
> buildroot rather than relying on modifications inside the lldpd project it
> can be simpler and faster to just remove them. NB for iproute2 that also
> provides some uapi include files the compilation is OK for kernel 7.3 with
> aarch64 as the provided types.h is more recent and __u128 is defined.

ok, right, same issue.

thanks Thibaut,
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-09-29 17:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 15:22 [Buildroot] [PATCH] package/lldpd: fix compilation issue with kernel 7.3 on aarch64 Thibaut Collet
2026-09-28 17:41 ` Vincent Jardin via buildroot
2026-09-28 21:27 ` Thomas Petazzoni via buildroot
2026-09-29  8:02   ` Thibaut Collet
2026-09-29 17:05     ` Vincent Jardin via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arvvyLRIyf-OFC3G@L30177.local \
    --to=buildroot@buildroot.org \
    --cc=thbt.cllt@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vjardin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.