All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Thomas Huth <thuth@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
	Paul Moore <paul@paul-moore.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: keys: Fix comment of search_process_keyrings_rcu()
Date: Wed, 30 Sep 2026 00:23:13 +0300	[thread overview]
Message-ID: <arwsQdH8JqgjeRnA@kernel.org> (raw)
In-Reply-To: <20260928072024.91664-1-thuth@redhat.com>

On Mon, Sep 28, 2026 at 09:20:23AM +0200, Thomas Huth wrote:
> search_my_process_keyrings() has been renamed to search_cred_keyrings_rcu()
> in commit e59428f721ee ("keys: Move the RCU locks outwards from the keyring
> search functions"), but one spot has been missed in a comment.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  security/keys/process_keys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
> index a63c46bb2d148..570c131d90d5c 100644
> --- a/security/keys/process_keys.c
> +++ b/security/keys/process_keys.c
> @@ -528,7 +528,7 @@ key_ref_t search_cred_keyrings_rcu(struct keyring_search_context *ctx)
>  
>  /*
>   * Search the process keyrings attached to the supplied cred for the first
> - * matching key in the manner of search_my_process_keyrings(), but also search
> + * matching key in the manner of search_cred_keyrings_rcu(), but also search
>   * the keys attached to the assumed authorisation key using its credentials if
>   * one is available.
>   *
> -- 
> 2.55.0
> 

Thanks.

Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>

Br, Jarkko

      parent reply	other threads:[~2026-09-29 21:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28  7:20 [PATCH] security: keys: Fix comment of search_process_keyrings_rcu() Thomas Huth
2026-09-28  7:23 ` sashiko-bot
2026-09-28 11:58 ` Jinjie Ruan
2026-09-29 21:23 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arwsQdH8JqgjeRnA@kernel.org \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.