From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Andrey Polivoda <apolivodaa433@gmail.com>
Subject: Re: [PATCH 3/3] target/i386/tcg: clarify return value of decode_insn
Date: Wed, 30 Sep 2026 16:30:27 +0800 [thread overview]
Message-ID: <arzIowSr4DlmtKa4@intel.com> (raw)
In-Reply-To: <20260930065406.738374-4-pbonzini@redhat.com>
On Wed, Sep 30, 2026 at 08:54:06AM +0200, Paolo Bonzini wrote:
> Date: Wed, 30 Sep 2026 08:54:06 +0200
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 3/3] target/i386/tcg: clarify return value of decode_insn
> X-Mailer: git-send-email 2.55.0
>
> It is clearer if decode_insn() returns whether a generator exists;
> if it does not, the entry is empty and all other checks such as
> validate_sse_prefix() or has_cpuid_feature() are moot.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/i386/tcg/decode-new.c.inc | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
next prev parent reply other threads:[~2026-09-30 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 6:54 [PATCH v2 0/3] target/i386/tcg: fix REPScalar with memory operand Paolo Bonzini
2026-09-30 6:54 ` [PATCH 1/3] target/i386/tcg: extract validate_cr0_exceptions() Paolo Bonzini
2026-09-30 8:29 ` Zhao Liu
2026-09-30 6:54 ` [PATCH 2/3] target/i386/tcg: move validate_vex() before all operand decoding Paolo Bonzini
2026-09-30 8:30 ` Zhao Liu
2026-09-30 6:54 ` [PATCH 3/3] target/i386/tcg: clarify return value of decode_insn Paolo Bonzini
2026-09-30 8:30 ` Zhao Liu [this message]
2026-09-30 19:49 ` Andrey Polivoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arzIowSr4DlmtKa4@intel.com \
--to=zhao1.liu@intel.com \
--cc=apolivodaa433@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.