From: Sabrina Dubroca <sd@queasysnail.net>
To: Qingfang Deng <qingfang.deng@linux.dev>
Cc: Chuck Lever <cel@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Dave Watson <davejwatson@fb.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] tls: skip empty data records in tls_sw_splice_read()
Date: Wed, 30 Sep 2026 11:47:46 +0200 [thread overview]
Message-ID: <arzawlad0OQ9pnBQ@krikkit> (raw)
In-Reply-To: <465aa0d9-b1b2-4c85-9cbf-e6ed296b7b12@linux.dev>
2026-09-30, 17:24:18 +0800, Qingfang Deng wrote:
> On 2026/9/30 17:13, Sabrina Dubroca wrote:
> > 2026-09-30, 13:26:36 +0800, Qingfang Deng wrote:
> > > tls_sw_splice_read() returns 0 after receiving an empty application
> > > record. This looks like EOF for splice(), even though the connection
> > > remains open and more data may be available.
> > >
> > > Consume empty application records and retry the receive path instead,
> > > following the approach used in tls_sw_read_sock() since commit
> > > 3be28e2c9cd0 ("net/tls: Consume empty data records in tls_sw_read_sock()").
> > This is similar to what Chuck proposed in July:
> > https://lore.kernel.org/all/20260726-tls-follow-on-v1-2-99bf4cc1c729@kernel.org
> >
> > but Chuck's patch had some extra bits (handling of the "released" flag
> > and of signal_pending).
> >
> > His series also had a selftest which should be included too
> > https://lore.kernel.org/all/20260726-tls-follow-on-v1-6-99bf4cc1c729@kernel.org/
>
> Thanks for the information. I prefer his series.
Let's see if he has the time/interest to continue work on this (since
he didn't send a v2, I'm guessing not).
Chuck, do you want to pick up that TLS fixes series again, or would
you rather let Qingfang finish off the "splice vs empty record"
patch+selftest based on what you had sent?
--
Sabrina
next prev parent reply other threads:[~2026-09-30 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 5:26 [PATCH net] tls: skip empty data records in tls_sw_splice_read() Qingfang Deng
2026-09-30 5:29 ` netdev-bot+sinfo
2026-09-30 5:49 ` Qingfang Deng
2026-09-30 9:13 ` Sabrina Dubroca
2026-09-30 9:24 ` Qingfang Deng
2026-09-30 9:47 ` Sabrina Dubroca [this message]
2026-09-30 13:45 ` Chuck Lever
2026-09-30 14:51 ` Sabrina Dubroca
2026-09-30 14:57 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arzawlad0OQ9pnBQ@krikkit \
--to=sd@queasysnail.net \
--cc=cel@kernel.org \
--cc=davejwatson@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingfang.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.