From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Lee Jones <lee@kernel.org>
Cc: vkoul@kernel.org, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, mfd@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 RESEND 2/2] mfd: cs42l43: Move to core detach helper
Date: Wed, 14 Oct 2026 16:34:23 +0100 [thread overview]
Message-ID: <as+g/3Qb2SpP6G0f@opensource.cirrus.com> (raw)
In-Reply-To: <20261014151800.GA1182143@google.com>
On Wed, Oct 14, 2026 at 04:18:00PM +0100, Lee Jones wrote:
> On Thu, 24 Sep 2026, Charles Keepax wrote:
>
> > Now the core has a helper to signal a device will detach from
> > the SoundWire bus, there is no need for the cs42l43 driver code
> > to separately track that. Switch to using the new core helper.
> >
> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > drivers/mfd/cs42l43-sdw.c | 2 --
> > drivers/mfd/cs42l43.c | 15 +--------------
> > include/linux/mfd/cs42l43.h | 1 -
> > 3 files changed, 1 insertion(+), 17 deletions(-)
>
> Does this need to go in as a set?
The MFD bit won't build without the SoundWire bit, so ideally.
Vinod has acked the series, although the original rather than
the resend.
https://lore.kernel.org/linux-sound/asC1SwHb4DZkJ4Pr@parshuram/
Thanks,
Charles
prev parent reply other threads:[~2026-10-14 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 12:05 [PATCH v2 RESEND 0/2] Add SoundWire detach helper Charles Keepax
2026-09-24 12:05 ` [PATCH v2 RESEND 1/2] soundwire: Add a helper function to indicate a device will detach Charles Keepax
2026-09-24 12:05 ` [PATCH v2 RESEND 2/2] mfd: cs42l43: Move to core detach helper Charles Keepax
2026-10-14 15:18 ` Lee Jones
2026-10-14 15:34 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as+g/3Qb2SpP6G0f@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.