From: Zorro Lang <zlang@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: daejun7.park@samsung.com, fstests@vger.kernel.org,
linux-ext4@vger.kernel.org,
Ojaswin Mujoo <ojaswin@linux.ibm.com>, Jan Kara <jack@suse.cz>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v2] generic: test that preallocated blocks still read zeroes after I/O errors
Date: Wed, 14 Oct 2026 23:31:19 +0800 [thread overview]
Message-ID: <as-dShqu7w8OBYm4@zlang-mailbox> (raw)
In-Reply-To: <aszSZ7Y2f8sIorpU@infradead.org>
On Mon, Oct 12, 2026 at 05:28:23AM -0700, Christoph Hellwig wrote:
> On Thu, Oct 08, 2026 at 07:18:24PM +0900, Daejun Park via B4 Relay wrote:
> > +# dm-error table sizes need zone alignment on zoned devices, and the check
> > +# needs a mounted file system.
> > +_scratch_mount
> > +test $FSTYP = xfs && _require_xfs_scratch_non_zoned
>
> The canonical way to write this would be
>
> _require_non_zoned_device $SCRATCH_RTDEV
Currently, there doesn't seem to be any usage of
"_require_non_zoned_device $SCRATCH_RTDEV" across the existing
test cases. So I'd prefer to leave this suggestion for the
author's next version, once it has been properly tested and
verified.
Thanks,
Zorro
>
> Otherwise looks good:
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-10-14 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:18 [PATCH v2] generic: test that preallocated blocks still read zeroes after I/O errors Daejun Park
2026-10-08 10:18 ` Daejun Park via B4 Relay
2026-10-08 10:29 ` sashiko-bot
2026-10-12 12:28 ` Christoph Hellwig
2026-10-14 15:31 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as-dShqu7w8OBYm4@zlang-mailbox \
--to=zlang@kernel.org \
--cc=daejun7.park@samsung.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.