From: Eric Blake <eblake@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>
Subject: Re: [PULL 02/15] qemu-nbd: Support -s and -l at the same time
Date: Tue, 13 Oct 2026 10:00:04 -0500 [thread overview]
Message-ID: <as0GYTta_kysg6vR@redhat.com> (raw)
In-Reply-To: <45a86ce8-6db9-4636-b64f-577469a50901@linaro.org>
On Fri, Oct 09, 2026 at 12:40:59PM +0200, Richard Henderson wrote:
> On 10/8/26 15:11, Eric Blake wrote:
> > @@ -1155,13 +1165,17 @@ int main(int argc, char **argv)
> >
> > blk_set_enable_write_cache(blk, !writethrough);
> >
> > + orig_bs = bs;
> > + if (flags & BDRV_O_SNAPSHOT) {
> > + orig_bs = bs->backing->bs;
> > + }
>
> tsan complains:
>
> ../qemu-nbd.c:1170:23: error: reading variable 'backing' requires holding
> mutex 'graph_lock' [-Werror,-Wthread-safety-analysis]
>
> https://gitlab.com/qemu-project/qemu/-/jobs/17055360066
Thanks for the heads up. I got a TSAN build working on my environment,
fixed up the problem, and posted a v2 pull request.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
next prev parent reply other threads:[~2026-10-13 15:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 13:11 [PULL 00/15] NBD patches through 2026-10-08 Eric Blake
2026-10-08 13:11 ` [PULL 01/15] maint: Update eblake's staging repo Eric Blake
2026-10-08 13:11 ` [PULL 02/15] qemu-nbd: Support -s and -l at the same time Eric Blake
2026-10-09 10:40 ` Richard Henderson
2026-10-13 15:00 ` Eric Blake [this message]
2026-10-08 13:11 ` [PULL 03/15] iotests: add test cases for failing flush after qemu-img convert Eric Blake
2026-10-08 13:11 ` [PULL 04/15] iotests.py: add filter_qemu() Eric Blake
2026-10-08 13:11 ` [PULL 05/15] block: report flush error during bdrv_close() Eric Blake
2026-10-08 13:11 ` [PULL 06/15] qemu-img: convert: flush target image after copying Eric Blake
2026-10-08 13:11 ` [PULL 07/15] nbd/client-connection: Fix client returning a closed channel Eric Blake
2026-10-08 13:11 ` [PULL 08/15] iotests: Add coverage for NBD connect thread start delay Eric Blake
2026-10-08 13:11 ` [PULL 09/15] migration: add QEMU_COUNTED_STRING_SIZE for counted string buffers Eric Blake
2026-10-08 13:11 ` [PULL 10/15] migration/block-dirty-bitmap: fix postcopy abort with bitmaps on several nodes Eric Blake
2026-10-08 13:11 ` [PULL 11/15] iotests/migrate-bitmaps-postcopy-test: add a bitmap on a second node Eric Blake
2026-10-08 13:11 ` [PULL 12/15] iotests/nbd-in-qcow2-chain: use default machine Eric Blake
2026-10-08 13:11 ` [PULL 13/15] iotests/nbd-tls-iothread: skip on non-x86 hardware Eric Blake
2026-10-08 13:11 ` [PULL 14/15] iotests/fuse-truncate: skip if FUSE is not usable Eric Blake
2026-10-08 13:11 ` [PULL 15/15] iotests/iothreads-nbd-export: Skip on s390 Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as0GYTta_kysg6vR@redhat.com \
--to=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.